Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 23654051: Fix IfBuilder to use instruction factories. Add missing instruction factories. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
mvstanton, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix IfBuilder to use instruction factories. Add missing instruction factories. This also makes the instruction constructors private and fixes all uses of the public constructors to use the factory methods instead. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16808

Patch Set 1 : #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -113 lines) Patch
M src/hydrogen.h View 1 4 chunks +17 lines, -17 lines 0 comments Download
M src/hydrogen.cc View 1 19 chunks +29 lines, -45 lines 0 comments Download
M src/hydrogen-instructions.h View 1 9 chunks +104 lines, -49 lines 0 comments Download
M src/hydrogen-osr.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Hey Michael, Here's the second part of the NumberToStringStub CL. It does some additional cleanup, ...
7 years, 3 months ago (2013-09-18 13:08:40 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-09-19 06:44:44 UTC) #2
Benedikt Meurer
Committed patchset #2 manually as r16808 (presubmit successful).
7 years, 3 months ago (2013-09-19 06:45:54 UTC) #3
mvstanton
7 years, 3 months ago (2013-09-19 07:55:38 UTC) #4
Message was sent while issue was closed.
yep, looks good.

Powered by Google App Engine
This is Rietveld 408576698