pdf: ifgnore shader colors applied for 0 range.

pdf: ifgnore shader colors applied for 0 range.

R=vandebo@chromium.org

Committed: https://code.google.com/p/skia/source/detail?r=11322

[vandebo (ex-Chrome), 2013-09-17 16:07:35]

https://codereview.chromium.org/23654044/diff/10001/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/23654044/diff/10001/src/pdf/SkPDFShader.cpp#n...
src/pdf/SkPDFShader.cpp:59: result->append("pop");
Looking more closely, it seems that this is not sufficient, you also need to
output curColor.

Probably also need a test (either a unit test if you can figure out how to build
one, or a gm).

[edisonn, 2013-09-17 16:42:06]

even better, do not call interpolate at all.
There is a test already, gm/gradients

https://codereview.chromium.org/23654044/diff/10001/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

https://codereview.chromium.org/23654044/diff/10001/src/pdf/SkPDFShader.cpp#n...
src/pdf/SkPDFShader.cpp:59: result->append("pop");
On 2013/09/17 16:07:35, vandebo wrote:
> Looking more closely, it seems that this is not sufficient, you also need to
> output curColor.
> 
> Probably also need a test (either a unit test if you can figure out how to
build
> one, or a gm).

changed the implementation

[vandebo (ex-Chrome), 2013-09-17 16:58:43]

LGTM

[edisonn, 2013-09-17 17:17:53]

Committed patchset #7 manually as r11322 (presubmit successful).