Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 23654041: Ensure constant truncation is only done when it is safe. (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Ensure constant truncation is only done when it is safe. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16766

Patch Set 1 : #

Total comments: 1

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/hydrogen-instructions.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 3 months ago (2013-09-16 15:12:19 UTC) #1
Michael Starzinger
LGTM if comment is addressed. https://codereview.chromium.org/23654041/diff/3001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/23654041/diff/3001/src/hydrogen-instructions.cc#newcode2584 src/hydrogen-instructions.cc:2584: Zone* zone, HGraphBuilder* builder) ...
7 years, 3 months ago (2013-09-17 12:10:13 UTC) #2
oliv
7 years, 3 months ago (2013-09-17 12:20:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698