Add panels as a single group of windows per display for overview window cycling.

ui/aura/window_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/window.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 1513 matching lines @@
   d2.Clear();
   w2->Hide();
   EXPECT_EQ(1, d2.hidden());
   EXPECT_EQ(0, d2.shown());
   d2.Clear();
   w2->Show();
   EXPECT_EQ(0, d2.hidden());
   EXPECT_EQ(1, d2.shown());
 }
 
+// Verifies that IsVisible will immediately return the state set by the last
+// call to SetVisible even if the window is animating visiblility.
+TEST_F(WindowTest, IsVisibleRespectsSetVisible) {
+  // We cannot short-circuit animations in this test.
+  ui::ScopedAnimationDurationScaleMode normal_duration_mode(
+      ui::ScopedAnimationDurationScaleMode::NORMAL_DURATION);
+
+  scoped_ptr<Window> w1(
+      CreateTestWindowWithBounds(gfx::Rect(0, 0, 100, 100), root_window()));
+  EXPECT_FALSE(!w1->layer());

[sky, 2013/09/13 21:46:44]

ASSERT (otherwise you're going to crash on 1547).

[flackr, 2013/09/13 22:28:38]

Done.

+
+  // Start an animation to hide the window.
+  {
+    ui::ScopedLayerAnimationSettings settings(w1->layer()->GetAnimator());
+    w1->layer()->SetVisible(false);
+  }
+
+  // Window is still visible, but is animating to be hidden.
+  EXPECT_TRUE(w1->IsVisible());
+  EXPECT_FALSE(w1->layer()->GetTargetVisibility());
+
+  // Now, explicitly hide the window and verify that IsVisible corresponds to
+  // the hidden state.
+  w1->Hide();
+  EXPECT_FALSE(w1->IsVisible());
+}
+
 TEST_F(WindowTest, IgnoreEventsTest) {
   TestWindowDelegate d11;
   TestWindowDelegate d12;
   TestWindowDelegate d111;
   TestWindowDelegate d121;
   scoped_ptr<Window> w1(CreateTestWindowWithDelegate(NULL, 1,
       gfx::Rect(0, 0, 500, 500), root_window()));
   scoped_ptr<Window> w11(CreateTestWindowWithDelegate(&d11, 11,
       gfx::Rect(0, 0, 500, 500), w1.get()));
   scoped_ptr<Window> w111(CreateTestWindowWithDelegate(&d111, 111,
@@ skipping 1501 matching lines @@
     o.ValidateState(index++, params);
 
     w1.reset();
     w2.reset();
   }
 
 }
 
 }  // namespace test
 }  // namespace aura