pdf: report NYI features, and fail gracefully when something is not supported in pdf.

src/pdf/SkPDFDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPDFDevice.h"
 
 #include "SkAnnotation.h"
@@ skipping 614 matching lines @@
     ContentEntry* entry() { return fContentEntry; }
 private:
     SkPDFDevice* fDevice;
     ContentEntry* fContentEntry;
     SkXfermode::Mode fXfermode;
     SkPDFFormXObject* fDstFormXObject;
 
     void init(const SkClipStack* clipStack, const SkRegion& clipRegion,
               const SkMatrix& matrix, const SkPaint& paint, bool hasText) {
         fDstFormXObject = NULL;
+        if (matrix.hasPerspective() ||

[vandebo (ex-Chrome), 2013/09/17 16:35:09]

The predominate style of this file is 80col.  The way I read the style guide
suggests that you should honor that style here unless it would be ugly.

[edisonn, 2013/09/17 17:32:04]

Done.

+                (paint.getShader() && paint.getShader()->getLocalMatrix().hasPerspective())) {
+            NOT_IMPLEMENTED(true, false);  // just report that PDF does not supports perspective
+                                           // TODO(edisonn): update the shape when possible
+                                           // or dump in an image otherwise
+            return;
+        }
+
         if (paint.getXfermode()) {
             paint.getXfermode()->asMode(&fXfermode);
         }
         fContentEntry = fDevice->setUpContentEntry(clipStack, clipRegion,
                                                    matrix, paint, hasText,
                                                    &fDstFormXObject);
     }
 };
 
 ////////////////////////////////////////////////////////////////////////////////
@@ skipping 27 matching lines @@
 // TODO(vandebo) change pageSize to SkSize.
 SkPDFDevice::SkPDFDevice(const SkISize& pageSize, const SkISize& contentSize,
                          const SkMatrix& initialTransform)
     : SkBitmapDevice(makeContentBitmap(contentSize, &initialTransform)),
       fPageSize(pageSize),
       fContentSize(contentSize),
       fLastContentEntry(NULL),
       fLastMarginContentEntry(NULL),
       fClipStack(NULL),
       fEncoder(NULL) {
+    // just report that PDF does not supports perspective
+    // TODO(edisonn): update the shape when possible
+    // or dump in an image otherwise
+    NOT_IMPLEMENTED(initialTransform.hasPerspective(), true);
+
     // Skia generally uses the top left as the origin but PDF natively has the
     // origin at the bottom left. This matrix corrects for that.  But that only
     // needs to be done once, we don't do it when layering.
     fInitialTransform.setTranslate(0, SkIntToScalar(pageSize.fHeight));
     fInitialTransform.preScale(SK_Scalar1, -SK_Scalar1);
     fInitialTransform.preConcat(initialTransform);
 
     SkIRect existingClip = SkIRect::MakeWH(this->width(), this->height());
     fExistingClipRegion.setRect(existingClip);
 
@@ skipping 78 matching lines @@
         return;
     }
     SkRect bbox = SkRect::MakeWH(SkIntToScalar(this->width()),
                                  SkIntToScalar(this->height()));
     SkMatrix totalTransform = fInitialTransform;
     totalTransform.preConcat(contentEntry->fState.fMatrix);
     SkMatrix inverse;
     if (!totalTransform.invert(&inverse)) {
         return;
     }
+
+    if (totalTransform.hasPerspective()) {

[vandebo (ex-Chrome), 2013/09/17 16:35:09]

This isn't needed.  totalTransform is formed from fInitialTransform and
contentENtry->fState.fMatrix, which have both already been checked for
perspective. Matrix inversion is an affine transform, so if the input was not
perspective, the output won't be either.

[edisonn, 2013/09/17 17:32:04]

Done.

+        NOT_IMPLEMENTED(true, false);  // just report that PDF does not supports perspective
+                                       // TODO(edisonn): update the shape when possible
+                                       // or dump in an image otherwise
+        return;
+    }
+
     inverse.mapRect(&bbox);
 
     SkPDFUtils::AppendRectangle(bbox, &contentEntry->fContent);
     SkPDFUtils::PaintPath(paint.getStyle(), SkPath::kWinding_FillType,
                           &contentEntry->fContent);
 }
 
 void SkPDFDevice::drawPoints(const SkDraw& d, SkCanvas::PointMode mode,
                              size_t count, const SkPoint* points,
                              const SkPaint& passedPaint) {
@@ skipping 118 matching lines @@
     SkMatrix matrix = *d.fMatrix;
     if (prePathMatrix) {
         if (paint.getPathEffect() || paint.getStyle() != SkPaint::kFill_Style) {
             if (!pathIsMutable) {
                 pathPtr = &modifiedPath;
                 pathIsMutable = true;
             }
             origPath.transform(*prePathMatrix, pathPtr);
         } else {
             if (!matrix.preConcat(*prePathMatrix)) {
+                // TODO(edisonn): report somewhow why we failed?

[vandebo (ex-Chrome), 2013/09/17 16:35:09]

Log statement?

[edisonn, 2013/09/17 17:32:04]

it is a todo, not looking for an answer in this cl. I am sure there are more
instances like this. i just want to mark it, if I see it.

                 return;
             }
         }
     }
 
+    if (matrix.hasPerspective()) {

[vandebo (ex-Chrome), 2013/09/17 16:35:09]

Not necessary, the matrix will eventually get checked in the ScopedContentEntry
init method.

[edisonn, 2013/09/17 17:32:04]

Done.

+        NOT_IMPLEMENTED(true, false);  // just report that PDF does not supports perspective
+                                       // TODO(edisonn): update the shape when possible
+                                       // or dump in an image otherwise
+        return;
+    }
+
     if (paint.getPathEffect()) {
         if (d.fClip->isEmpty()) {
             return;
         }
         if (!pathIsMutable) {
             pathPtr = &modifiedPath;
             pathIsMutable = true;
         }
         bool fill = paint.getFillPath(origPath, pathPtr);
 
@@ skipping 962 matching lines @@
                                      const SkPaint& paint) {
     SkMatrix scaled;
     // Adjust for origin flip.
     scaled.setScale(SK_Scalar1, -SK_Scalar1);
     scaled.postTranslate(0, SK_Scalar1);
     // Scale the image up from 1x1 to WxH.
     SkIRect subset = SkIRect::MakeWH(bitmap.width(), bitmap.height());
     scaled.postScale(SkIntToScalar(subset.width()),
                      SkIntToScalar(subset.height()));
     scaled.postConcat(matrix);
+
+    if (scaled.hasPerspective()) {

[vandebo (ex-Chrome), 2013/09/17 16:35:09]

Not needed - scaled in passed into ScopedContentEntry...

[edisonn, 2013/09/17 17:32:04]

Done.

+        NOT_IMPLEMENTED(true, false);  // just report that PDF does not supports perspective
+                                       // TODO(edisonn): update the shape when possible
+                                       // or dump in an image otherwise
+        return;
+    }
+
     ScopedContentEntry content(this, clipStack, clipRegion, scaled, paint);
     if (!content.entry()) {
         return;
     }
 
     if (srcRect && !subset.intersect(*srcRect)) {
         return;
     }
 
     SkPDFImage* image = SkPDFImage::CreateImage(bitmap, subset, fEncoder);
     if (!image) {
         return;
     }
 
     fXObjectResources.push(image);  // Transfer reference.
     SkPDFUtils::DrawFormXObject(fXObjectResources.count() - 1,
                                 &content.entry()->fContent);
 }
 
 bool SkPDFDevice::onReadPixels(const SkBitmap& bitmap, int x, int y,
                                SkCanvas::Config8888) {
     return false;
 }
 
 bool SkPDFDevice::allowImageFilter(SkImageFilter*) {
     return false;
 }