Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2365403003: [api] Add documentation for various HasProperty functions. (Closed)

Created:
4 years, 2 months ago by Franzi
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add documentation for various HasProperty functions. Add documentation for Has(), HasOwnProperty(), and HasRealNamedProperty() that points out their differences and links to the other functions. BUG=v8:5433 Committed: https://crrev.com/ab486146d4a446a3e4f654c0671111d6637b5436 Cr-Commit-Position: refs/heads/master@{#39818}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add note about non masking interceptors. #

Patch Set 3 : Also link to indexed callbacks from flags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -6 lines) Patch
M include/v8.h View 1 2 3 chunks +55 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Franzi
Hi Jochen, I added a few lines of documentation for the HasProperty() functions in the ...
4 years, 2 months ago (2016-09-26 15:12:44 UTC) #2
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/2365403003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/2365403003/diff/1/include/v8.h#newcode3167 include/v8.h:3167: * call interceptors. you could add ...
4 years, 2 months ago (2016-09-26 15:16:12 UTC) #3
Franzi
> https://codereview.chromium.org/2365403003/diff/1/include/v8.h#newcode3167 > include/v8.h:3167: * call interceptors. > you could add that usually, you should ...
4 years, 2 months ago (2016-09-27 10:45:51 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-27 19:10:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365403003/40001
4 years, 2 months ago (2016-09-28 09:28:04 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-28 09:57:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:57:55 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab486146d4a446a3e4f654c0671111d6637b5436
Cr-Commit-Position: refs/heads/master@{#39818}

Powered by Google App Engine
This is Rietveld 408576698