Quiet a -Wcomma warning.

Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002

NOTREECHECKS=true

Committed: https://skia.googlesource.com/skia/+/85552e4f9d65c8e751d106fae173374346863cdf

[mtklein_C, 2016-09-26 14:25:46]

Description was changed from

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.

BUG=skia:
==========

to

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

[mtklein_C, 2016-09-26 14:27:04]

Description was changed from

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

to

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would probably be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

[mtklein_C, 2016-09-26 14:27:27]

Description was changed from

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would probably be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

to

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

[mtklein_C, 2016-09-26 14:28:28]

mtklein@chromium.org changed reviewers:
+ bsalomon@google.com

[mtklein_C, 2016-09-26 14:28:28]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:28:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 14:28:41]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-09-26 20:28 UTC

[bsalomon, 2016-09-26 14:39:41]

There is another instance of this in GrVkPipelineState.cpp (only compiled if
skia_vulkan=1).

The latter parsing wouldn't have compiled as the type of the second expression
used with the comma operator is not assignable to fp.

[bsalomon, 2016-09-26 14:44:04]

lgtm

[mtklein, 2016-09-26 14:44:33]

On 2016/09/26 14:39:41, bsalomon wrote:
> There is another instance of this in GrVkPipelineState.cpp (only compiled if
> skia_vulkan=1).
Done.

> The latter parsing wouldn't have compiled as the type of the second expression
> used with the comma operator is not assignable to fp.

Phew.

[mtklein_C, 2016-09-26 14:44:44]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-26 14:44:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-26 15:35:58]

Description was changed from

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002
==========

to

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002

NOTREECHECKS=true
==========

[mtklein_C, 2016-09-26 15:38:23]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-09-26 15:38:25]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-26 15:38:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 15:39:45]

Description was changed from

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002

NOTREECHECKS=true
==========

to

==========
Quiet a -Wcomma warning.

Clang's got a warning -Wcomma that warns about possible unintentional uses of
the comma operator, usually where a semicolon looks itended.

I don't think there's a bug here, but a semicolon does work just as well
and reads a bit more conventionally.  Though, I'm not actually sure how this
parses, as fp = ...; glslFP = ...; or fp = (..., glsl = ...).  The second
would most definitely be a bug.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365403002

NOTREECHECKS=true

Committed:
https://skia.googlesource.com/skia/+/85552e4f9d65c8e751d106fae173374346863cdf
==========

[commit-bot: I haz the power, 2016-09-26 15:39:46]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/85552e4f9d65c8e751d106fae173374346863cdf