src/ia32/stub-cache-ia32.cc - Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: rebase to master and address comments Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index d2da43ea7bf144fc4c1f5941a3edc3bf34135a98..5fe0110732adb84e223c150b314523139df517d2 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -859,7 +859,7 @@ void BaseStoreStubCompiler::GenerateStoreTransition(MacroAssembler* masm,

__ SmiUntag(value_reg);

if (CpuFeatures::IsSupported(SSE2)) {

CpuFeatureScope use_sse2(masm, SSE2);

- __ cvtsi2sd(xmm0, value_reg);

+ __ Cvtsi2sd(xmm0, value_reg);

} else {

__ push(value_reg);

__ fild_s(Operand(esp, 0));

@@ -1038,7 +1038,7 @@ void BaseStoreStubCompiler::GenerateStoreField(MacroAssembler* masm,