Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: rebase to master and address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 void JumpIfNotUniqueName(Operand operand, Label* not_unique_name, 777 void JumpIfNotUniqueName(Operand operand, Label* not_unique_name,
778 Label::Distance distance = Label::kFar); 778 Label::Distance distance = Label::kFar);
779 779
780 // --------------------------------------------------------------------------- 780 // ---------------------------------------------------------------------------
781 // Macro instructions. 781 // Macro instructions.
782 782
783 // Load a register with a long value as efficiently as possible. 783 // Load a register with a long value as efficiently as possible.
784 void Set(Register dst, int64_t x); 784 void Set(Register dst, int64_t x);
785 void Set(const Operand& dst, int64_t x); 785 void Set(const Operand& dst, int64_t x);
786 786
787 // cvtsi2sd instruction only writes to the low 64-bit of dst register, which
788 // hinders register renaming and makes dependence chains longer. So we use
789 // xorps to clear the dst register before cvtsi2sd to solve this issue.
790 void Cvtlsi2sd(XMMRegister dst, Register src);
791 void Cvtlsi2sd(XMMRegister dst, const Operand& src);
792
787 // Move if the registers are not identical. 793 // Move if the registers are not identical.
788 void Move(Register target, Register source); 794 void Move(Register target, Register source);
789 795
790 // Bit-field support. 796 // Bit-field support.
791 void TestBit(const Operand& dst, int bit_index); 797 void TestBit(const Operand& dst, int bit_index);
792 798
793 // Handle support 799 // Handle support
794 void Move(Register dst, Handle<Object> source); 800 void Move(Register dst, Handle<Object> source);
795 void Move(const Operand& dst, Handle<Object> source); 801 void Move(const Operand& dst, Handle<Object> source);
796 void Cmp(Register dst, Handle<Object> source); 802 void Cmp(Register dst, Handle<Object> source);
(...skipping 767 matching lines...) Expand 10 before | Expand all | Expand 10 after
1564 masm->popfq(); \ 1570 masm->popfq(); \
1565 } \ 1571 } \
1566 masm-> 1572 masm->
1567 #else 1573 #else
1568 #define ACCESS_MASM(masm) masm-> 1574 #define ACCESS_MASM(masm) masm->
1569 #endif 1575 #endif
1570 1576
1571 } } // namespace v8::internal 1577 } } // namespace v8::internal
1572 1578
1573 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1579 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698