Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: rebase to master and address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 __ jmp(&done); 379 __ jmp(&done);
380 380
381 // Conversion loop. 381 // Conversion loop.
382 __ bind(&loop); 382 __ bind(&loop);
383 __ movq(rbx, 383 __ movq(rbx,
384 FieldOperand(r8, r9, times_pointer_size, FixedArray::kHeaderSize)); 384 FieldOperand(r8, r9, times_pointer_size, FixedArray::kHeaderSize));
385 // r9 : current element's index 385 // r9 : current element's index
386 // rbx: current element (smi-tagged) 386 // rbx: current element (smi-tagged)
387 __ JumpIfNotSmi(rbx, &convert_hole); 387 __ JumpIfNotSmi(rbx, &convert_hole);
388 __ SmiToInteger32(rbx, rbx); 388 __ SmiToInteger32(rbx, rbx);
389 __ cvtlsi2sd(xmm0, rbx); 389 __ Cvtlsi2sd(xmm0, rbx);
390 __ movsd(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize), 390 __ movsd(FieldOperand(r14, r9, times_8, FixedDoubleArray::kHeaderSize),
391 xmm0); 391 xmm0);
392 __ jmp(&entry); 392 __ jmp(&entry);
393 __ bind(&convert_hole); 393 __ bind(&convert_hole);
394 394
395 if (FLAG_debug_code) { 395 if (FLAG_debug_code) {
396 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex); 396 __ CompareRoot(rbx, Heap::kTheHoleValueRootIndex);
397 __ Assert(equal, kObjectFoundInSmiOnlyArray); 397 __ Assert(equal, kObjectFoundInSmiOnlyArray);
398 } 398 }
399 399
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize. 762 // argument_count_reg_ * times_pointer_size + (receiver - 1) * kPointerSize.
763 return Operand(base_reg_, argument_count_reg_, times_pointer_size, 763 return Operand(base_reg_, argument_count_reg_, times_pointer_size,
764 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize); 764 displacement_to_last_argument + (receiver - 1 - index) * kPointerSize);
765 } 765 }
766 } 766 }
767 767
768 768
769 } } // namespace v8::internal 769 } } // namespace v8::internal
770 770
771 #endif // V8_TARGET_ARCH_X64 771 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698