Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: rebase to master and address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 // Store the function for the given builtin in the target register. 359 // Store the function for the given builtin in the target register.
360 void GetBuiltinFunction(Register target, Builtins::JavaScript id); 360 void GetBuiltinFunction(Register target, Builtins::JavaScript id);
361 361
362 // Store the code object for the given builtin in the target register. 362 // Store the code object for the given builtin in the target register.
363 void GetBuiltinEntry(Register target, Builtins::JavaScript id); 363 void GetBuiltinEntry(Register target, Builtins::JavaScript id);
364 364
365 // Expression support 365 // Expression support
366 void Set(Register dst, const Immediate& x); 366 void Set(Register dst, const Immediate& x);
367 void Set(const Operand& dst, const Immediate& x); 367 void Set(const Operand& dst, const Immediate& x);
368 368
369 // cvtsi2sd instruction only writes to the low 64-bit of dst register, which
370 // hinders register renaming and makes dependence chains longer. So we use
371 // xorps to clear the dst register before cvtsi2sd to solve this issue.
372 void Cvtsi2sd(XMMRegister dst, Register src) { Cvtsi2sd(dst, Operand(src)); }
373 void Cvtsi2sd(XMMRegister dst, const Operand& src);
374
369 // Support for constant splitting. 375 // Support for constant splitting.
370 bool IsUnsafeImmediate(const Immediate& x); 376 bool IsUnsafeImmediate(const Immediate& x);
371 void SafeSet(Register dst, const Immediate& x); 377 void SafeSet(Register dst, const Immediate& x);
372 void SafePush(const Immediate& x); 378 void SafePush(const Immediate& x);
373 379
374 // Compare object type for heap object. 380 // Compare object type for heap object.
375 // Incoming register is heap_object and outgoing register is map. 381 // Incoming register is heap_object and outgoing register is map.
376 void CmpObjectType(Register heap_object, InstanceType type, Register map); 382 void CmpObjectType(Register heap_object, InstanceType type, Register map);
377 383
378 // Compare instance type for map. 384 // Compare instance type for map.
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
1074 } \ 1080 } \
1075 masm-> 1081 masm->
1076 #else 1082 #else
1077 #define ACCESS_MASM(masm) masm-> 1083 #define ACCESS_MASM(masm) masm->
1078 #endif 1084 #endif
1079 1085
1080 1086
1081 } } // namespace v8::internal 1087 } } // namespace v8::internal
1082 1088
1083 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 1089 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698