Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Side by Side Diff: src/ia32/codegen-ia32.cc

Issue 23654026: Use xorps to break the cvtsi2sd unnecessary dependence due to its partially written (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: rebase to master and address comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 __ bind(&loop); 761 __ bind(&loop);
762 __ mov(ebx, FieldOperand(esi, edi, times_2, FixedArray::kHeaderSize)); 762 __ mov(ebx, FieldOperand(esi, edi, times_2, FixedArray::kHeaderSize));
763 // ebx: current element from source 763 // ebx: current element from source
764 // edi: index of current element 764 // edi: index of current element
765 __ JumpIfNotSmi(ebx, &convert_hole); 765 __ JumpIfNotSmi(ebx, &convert_hole);
766 766
767 // Normal smi, convert it to double and store. 767 // Normal smi, convert it to double and store.
768 __ SmiUntag(ebx); 768 __ SmiUntag(ebx);
769 if (CpuFeatures::IsSupported(SSE2)) { 769 if (CpuFeatures::IsSupported(SSE2)) {
770 CpuFeatureScope fscope(masm, SSE2); 770 CpuFeatureScope fscope(masm, SSE2);
771 __ cvtsi2sd(xmm0, ebx); 771 __ Cvtsi2sd(xmm0, ebx);
772 __ movdbl(FieldOperand(eax, edi, times_4, FixedDoubleArray::kHeaderSize), 772 __ movdbl(FieldOperand(eax, edi, times_4, FixedDoubleArray::kHeaderSize),
773 xmm0); 773 xmm0);
774 } else { 774 } else {
775 __ push(ebx); 775 __ push(ebx);
776 __ fild_s(Operand(esp, 0)); 776 __ fild_s(Operand(esp, 0));
777 __ pop(ebx); 777 __ pop(ebx);
778 __ fstp_d(FieldOperand(eax, edi, times_4, FixedDoubleArray::kHeaderSize)); 778 __ fstp_d(FieldOperand(eax, edi, times_4, FixedDoubleArray::kHeaderSize));
779 } 779 }
780 __ jmp(&entry); 780 __ jmp(&entry);
781 781
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
1177 Code* stub = GetCodeAgeStub(age, parity); 1177 Code* stub = GetCodeAgeStub(age, parity);
1178 CodePatcher patcher(sequence, young_length); 1178 CodePatcher patcher(sequence, young_length);
1179 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32); 1179 patcher.masm()->call(stub->instruction_start(), RelocInfo::NONE32);
1180 } 1180 }
1181 } 1181 }
1182 1182
1183 1183
1184 } } // namespace v8::internal 1184 } } // namespace v8::internal
1185 1185
1186 #endif // V8_TARGET_ARCH_IA32 1186 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698