Issue 23654015: Avoid using !OS() constructs.

Issue 23654015: Avoid using !OS() constructs. (Closed)

Created:
7 years, 3 months ago by lgombos

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, dsinclair, eae+blinkwatch, danakj, dglazkov+blink, Rik, groby+blinkspell_chromium.org, Stephen Chennney, jeez, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Avoid using !OS() constructs. Simplify guards to take advantage of the facts that !OS(POSIX) means OS(WIN). Also fix a bug spotted for OS(ANDROID). Make OS(ANDROID) behave the same way as OS(WIN) and OS(MACOSX) inside EventHandler::shouldTurnVerticalTicksIntoHorizontal(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157500

Patch Set 1 #

Patch Set 2 : git cl try #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : Fix EventHandler::shouldTurnVerticalTicksIntoHorizontal() for Android #

Patch Set 5 : Fix merge #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
M	Source/core/page/EventHandler.cpp	View	1 2 3 4	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/core/platform/graphics/FontPlatformData.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/EditorClientImpl.cpp	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/WebFrameImpl.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 2 3 4	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

lgombos

!OS() is often confusing, so try to list OS() guards explicitly.

7 years, 3 months ago (2013-09-08 23:39:16 UTC) #1

abarth-chromium

lgtm https://codereview.chromium.org/23654015/diff/3001/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/23654015/diff/3001/Source/core/page/EventHandler.cpp#newcode2095 Source/core/page/EventHandler.cpp:2095: #if OS(WINDOWS) || OS(MACOSX) Should Android do this ...

7 years, 3 months ago (2013-09-09 17:26:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23654015/24001

7 years, 3 months ago (2013-09-10 01:49:04 UTC) #5

Message was sent while issue was closed.

Change committed as 157500

Expand Messages | Collapse Messages