Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2240)

Unified Diff: chrome/browser/net/client_hints_unittest.cc

Issue 23654014: Updated Client-Hints patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed issues raised in review by mmenke and bengr Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/client_hints.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/client_hints_unittest.cc
diff --git a/chrome/browser/net/client_hints_unittest.cc b/chrome/browser/net/client_hints_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..679d6c76610884ae9dd26d531c57865f44f9a227
--- /dev/null
+++ b/chrome/browser/net/client_hints_unittest.cc
@@ -0,0 +1,48 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/client_hints.h"
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ClientHintsTest : public testing::Test {
+ public:
+ void UpdateScreenInfo(float pixel_ratio) {
+ client_hints_.UpdateScreenInfo(&pixel_ratio);
+ };
+
+ protected:
+ ClientHints client_hints_;
+};
+
+TEST_F(ClientHintsTest, HintsWellFormatted) {
+ UpdateScreenInfo(1.567f);
+ std::string hint = client_hints_.GetString();
+ EXPECT_EQ("dpr=1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsWellFormattedWithNonEnLocale) {
+ std::setlocale(LC_ALL, "fr_FR.UTF-8");
+ UpdateScreenInfo(1.567f);
+ std::string hint = client_hints_.GetString();
+ EXPECT_EQ("dpr=1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
+ UpdateScreenInfo(-1.567f);
+ std::string hint = client_hints_.GetString();
+ EXPECT_EQ("", hint);
+
+ UpdateScreenInfo(1.567f);
+ hint = client_hints_.GetString();
+ EXPECT_EQ("dpr=1.57", hint);
+
+ UpdateScreenInfo(0.0f);
+ hint = client_hints_.GetString();
+ // Hints should be last known good values.
+ EXPECT_EQ("dpr=1.57", hint);
+}
+
« no previous file with comments | « chrome/browser/net/client_hints.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698