Updated Client-Hints patch

chrome/browser/net/client_hints_unittest.cc

Index: chrome/browser/net/client_hints_unittest.cc
diff --git a/chrome/browser/net/client_hints_unittest.cc b/chrome/browser/net/client_hints_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7dc8d49acbdd041157840915863d4b505ef24824
--- /dev/null
+++ b/chrome/browser/net/client_hints_unittest.cc
@@ -0,0 +1,52 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[bengr, 2013/09/11 16:32:36]

2013, remove (c)

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/client_hints.h"
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ClientHintsTest : public testing::Test {
+ public:
+  void UpdateScreenInfo(int width, int height, float pixel_ratio) {
+    ClientHints::ScreenInfo info;
+    info.width = width;
+    info.height = height;
+    info.pixel_ratio = pixel_ratio;
+    client_hints_.UpdateScreenInfo(&info);
+  };
+
+ protected:
+  ClientHints client_hints_;
+};
+
+TEST_F(ClientHintsTest, HintsWellFormatted) {
+  UpdateScreenInfo(100, 200, 1.567f);

[bengr, 2013/09/11 16:32:36]

remove device width/height from tests because they won't be used.

+  std::string hint = client_hints_.GetScreenInfoHints();
+  EXPECT_EQ("dpr=1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsWellFormattedWithNonEnLocale) {
+  std::setlocale(LC_ALL, "fr_FR.UTF-8");
+  UpdateScreenInfo(100, 200, 1.567f);
+  std::string hint = client_hints_.GetScreenInfoHints();
+  EXPECT_EQ("dpr=1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
+  UpdateScreenInfo(-100, -200, -1.567f);
+  std::string hint = client_hints_.GetScreenInfoHints();
+  EXPECT_EQ("", hint);
+
+  UpdateScreenInfo(100, 200, 1.567f);
+  hint = client_hints_.GetScreenInfoHints();
+  EXPECT_EQ("dpr=1.57", hint);
+
+  UpdateScreenInfo(100, 200, 0.0f);
+  hint = client_hints_.GetScreenInfoHints();
+  // Hints should be last known good values.
+  EXPECT_EQ("dpr=1.57", hint);
+}
+