ash: Clean up window cycling accelerator code

ash: Clean up window cycling accelerator code

* Eliminate unused CYCLE_BACKWARD_LINEAR action -- linear cycling only goes
  forward.
* Consolidate the window cycling code into helper functions

BUG=none
TEST=ash_unittests Accelerator*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221430

[James Cook, 2013-09-04 23:16:46]

flackr, PTAL

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_controller.cc (left):

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
ash/accelerators/accelerator_controller.cc:106:
window_cycle_controller()->HandleLinearCycleWindow();
Note that this ignores |direction|. Heh. :-)

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
ash/accelerators/accelerator_controller.cc:90: void HandleCycleBackwardMRU(const
ui::Accelerator& accelerator) {
These are the implementations from the old switch statement with the old
HandleCycle*() functions inlined.

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.h (left):

https://codereview.chromium.org/23654011/diff/3001/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.h:147: // The number of elements in
kAcceleratorData.
While working on an earlier CL I found these comments interfered with my ability
to see all the categories of accelerators, so I removed them.  They didn't seem
that useful.

[James Cook, 2013-09-04 23:35:25]

Ah, this patch is dependent on https://codereview.chromium.org/23611005/ - it
won't compile until that lands.

[James Cook, 2013-09-04 23:46:31]

rebase

[flackr, 2013-09-05 00:26:14]

LGTM but you'll have merge conflicts with my CL that just landed to enable
overview by default.

https://codereview.chromium.org/23654011/diff/4005/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/23654011/diff/4005/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.cc:41: // TODO(jamescook): Remove this
shortcut when overview mode is the default.
Why even have it now when it does the same action? Does anyone actually push
shift+F5 to cycle?

[commit-bot: I haz the power, 2013-09-05 03:05:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/23654011/19001

[James Cook, 2013-09-05 03:05:46]

https://codereview.chromium.org/23654011/diff/4005/ash/accelerators/accelerat...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/23654011/diff/4005/ash/accelerators/accelerat...
ash/accelerators/accelerator_table.cc:41: // TODO(jamescook): Remove this
shortcut when overview mode is the default.
On 2013/09/05 00:26:14, flackr wrote:
> Why even have it now when it does the same action? Does anyone actually push
> shift+F5 to cycle?

I doubt anyone uses it. Removed the shortcut.

[commit-bot: I haz the power, 2013-09-05 03:44:46]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 15:05:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/23654011/19001

[commit-bot: I haz the power, 2013-09-05 15:06:14]

Change committed as 221430