Add tools/swarm_client/third_party as unknown license.

Add tools/swarm_client/third_party as unknown license.

This is because colorama is missing license header on its files, even if
LICENSE.txt is included. Note that these files are not needed for the build
process to complete.

R=phajdan.jr@chromium.org
NOTRY=true
BUG=colorama:44
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221296

[M-A Ruel, 2013-09-04 19:03:16]

It broke
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
but wasn't seen in the try jobs I ran at
https://chromiumcodereview.appspot.com/23593007.

In particular,
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...
doesn't run checklicense.

[Paweł Hajdan Jr., 2013-09-04 19:10:44]

"not lgtm" for following reasons:

The error message is:

'tools/swarm_client/third_party/colorama/ansitowin32.py' has non-whitelisted
license 'UNKNOWN'
'tools/swarm_client/third_party/colorama/ansi.py' has non-whitelisted license
'UNKNOWN'
'tools/swarm_client/third_party/colorama/__init__.py' has non-whitelisted
license 'UNKNOWN'
'tools/swarm_client/third_party/colorama/initialise.py' has non-whitelisted
license 'UNKNOWN'
'tools/swarm_client/third_party/colorama/win32.py' has non-whitelisted license
'UNKNOWN'
'tools/swarm_client/third_party/colorama/winterm.py' has non-whitelisted license
'UNKNOWN'

Please only exclude tools/swarm_client/third_party/colorama.

Then please file a colorama bug to include a license header in all files. Put
the link to that bug in checklicenses.py.

[M-A Ruel, 2013-09-04 19:19:40]

Filed bug and updated.

[Paweł Hajdan Jr., 2013-09-04 19:33:04]

Thanks, just one minor thing.

https://codereview.chromium.org/23654007/diff/4001/tools/checklicenses/checkl...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/23654007/diff/4001/tools/checklicenses/checkl...
tools/checklicenses/checklicenses.py:365:
'tools/swarm_client/third_party/colorama': [  # http://crbug.com/285352
Please file a bug at https://code.google.com/p/colorama/

Sorry if that was not clear earlier. You can mark the chromium bug blocked on
the colorama bug, or just close it altogether in favor of the colorama one.

Put the colorama bug link here.

[M-A Ruel, 2013-09-04 22:36:43]

updated

[Paweł Hajdan Jr., 2013-09-04 22:53:40]

LGTM with nits.

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
tools/checklicenses/checklicenses.py:365: #
https://code.google.com/p/colorama/issues/detail?id=44
nit: Add empty line above to make it unambiguous to which lines the comment
applies.

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
tools/checklicenses/checklicenses.py:368: ],
nit: And empty line below for the same reason.

This matches a convention used in this file, see e.g. pyelftools.

[M-A Ruel, 2013-09-04 23:12:46]

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
tools/checklicenses/checklicenses.py:365: #
https://code.google.com/p/colorama/issues/detail?id=44
On 2013/09/04 22:53:40, Paweł Hajdan Jr. wrote:
> nit: Add empty line above to make it unambiguous to which lines the comment
> applies.

Done.

https://codereview.chromium.org/23654007/diff/9001/tools/checklicenses/checkl...
tools/checklicenses/checklicenses.py:368: ],
On 2013/09/04 22:53:40, Paweł Hajdan Jr. wrote:
> nit: And empty line below for the same reason.
> 
> This matches a convention used in this file, see e.g. pyelftools.

Done.

[commit-bot: I haz the power, 2013-09-04 23:14:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/23654007/14001

[commit-bot: I haz the power, 2013-09-04 23:32:56]

Change committed as 221296