Issue 23654005: ARM Bug fix: ConstantPoolSizeAt()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23654005: ARM Bug fix: ConstantPoolSizeAt() (Closed)

Created:
7 years, 3 months ago by Bangfu

Modified:
7 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the code will be treated as constant pool when printing code in ARM disassembler. BUG=none TEST=none R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16419

Patch Set 1 : updated #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/arm/disasm-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r16419 (presubmit successful).

7 years, 3 months ago (2013-08-29 11:49:54 UTC) #2

Benedikt Meurer

Your patch broke the ARM tests, we had to revert. Please submit a new patch ...

7 years, 3 months ago (2013-08-30 07:31:32 UTC) #3

Bangfu

7 years, 3 months ago (2013-09-02 08:06:55 UTC) #4

Message was sent while issue was closed.

On 2013/08/30 07:31:32, Benedikt Meurer wrote:
> Your patch broke the ARM tests, we had to revert. Please submit a new patch
that
> actually passes the test suite.

Sorry about that, we did not realize the bug had been fixed in the latest
bleeding edge.

Expand Messages | Collapse Messages