Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2365393002: Revert of Preparse functions in the scope that was created when parsing of the function was started (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Preparse functions in the scope that was created when parsing of the function was started (patchset #2 id:20001 of https://codereview.chromium.org/2370713003/ ) Reason for revert: Needed for https://codereview.chromium.org/2373443003/ Original issue's description: > Preparse functions in the scope that was created when parsing of the function was started > > This reduces the number of scopes for lazily parsed top-level functions from 3 to 1 > > BUG=v8:5209 > > Committed: https://crrev.com/9618d095903c604a032b33792c068f4a6169503c > Cr-Commit-Position: refs/heads/master@{#39725} TBR=marja@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5209 Committed: https://crrev.com/0cef7100da0b609403c9026fb7307192a898a390 Cr-Commit-Position: refs/heads/master@{#39729}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/parsing/parser.cc View 4 chunks +29 lines, -14 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/parsing/preparser.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of Preparse functions in the scope that was created when parsing of the ...
4 years, 2 months ago (2016-09-26 14:02:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365393002/1
4 years, 2 months ago (2016-09-26 14:02:11 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 14:02:21 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0cef7100da0b609403c9026fb7307192a898a390 Cr-Commit-Position: refs/heads/master@{#39729}
4 years, 2 months ago (2016-09-26 14:02:43 UTC) #6
Camillo Bruni
4 years, 2 months ago (2016-09-27 09:49:02 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2377593002/ by cbruni@chromium.org.

The reason for reverting is: Stability thief found, relanding speculative
reverts..

Powered by Google App Engine
This is Rietveld 408576698