Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2365383003: De-virtualize CPDFSDK_AnnotHandlerMgr (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

De-virtualize CPDFSDK_AnnotHandlerMgr It has no sub-classes or super-classes, so no need for virtual. Committed: https://pdfium.googlesource.com/pdfium/+/9c33e89a43fd316fb42a7134d34585eb04c60416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -65 lines) Patch
M fpdfsdk/include/cpdfsdk_annothandlermgr.h View 1 chunk +59 lines, -65 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Tom Sepez
Lei, for review while Dan is away ...
4 years, 2 months ago (2016-09-26 19:03:30 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-09-26 19:08:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365383003/1
4 years, 2 months ago (2016-09-26 19:12:27 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 19:29:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9c33e89a43fd316fb42a7134d34585eb04c6...

Powered by Google App Engine
This is Rietveld 408576698