Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2365373004: [turbofan] Remove the representation dimension from Type. (Closed)

Created:
4 years, 2 months ago by mvstanton
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the representation dimension from Type. Adding this back in because it's not part of the stability issue. BUG=chromium:649967 TBR=jarin@chromium.org Committed: https://crrev.com/c9cc3d164dda31e83b3538eaa6f9b5ab889acd2a Cr-Commit-Position: refs/heads/master@{#39761}

Patch Set 1 #

Patch Set 2 : Include another CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -389 lines) Patch
M src/compiler/representation-change.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M src/compiler/types.h View 1 11 chunks +35 lines, -127 lines 0 comments Download
M src/compiler/types.cc View 1 33 chunks +80 lines, -178 lines 0 comments Download
M test/cctest/test-types.cc View 2 chunks +0 lines, -68 lines 0 comments Download
M test/cctest/types-fuzz.h View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365373004/1
4 years, 2 months ago (2016-09-27 10:22:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365373004/20001
4 years, 2 months ago (2016-09-27 10:41:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 11:12:29 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 11:12:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9cc3d164dda31e83b3538eaa6f9b5ab889acd2a
Cr-Commit-Position: refs/heads/master@{#39761}

Powered by Google App Engine
This is Rietveld 408576698