Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2365353006: Revert of [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. (patchset #6 id:100001 of https://codereview.chromium.org/2367593003/ ) Reason for revert: Still blows up on the main waterfall even after Jakob's fix: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11557/steps/Check/logs/typedarray-indexing https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11557/steps/Check/logs/typedarray https://build.chromium.org/p/client.v8/builders/V8%20Win64/builds/12982/steps/Check/logs/typedarray Original issue's description: > [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. > > This matches current Crankshaft/fullcodegen behavior more closely and > thus reduces the chances that we run into unnecessary polymorphism due > to the field representation tracking in our object model. > > R=jarin@chromium.org > BUG=v8:5267 > > Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca99c0ef > Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 > Committed: https://crrev.com/ddf792beb3a72f6dba83e94fc8ada03ebf1630bd > Cr-Original-Commit-Position: refs/heads/master@{#39692} > Cr-Commit-Position: refs/heads/master@{#39748} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267 Committed: https://crrev.com/76b68915b3b87ac6da9408a4d5d756cfe0440d8b Cr-Commit-Position: refs/heads/master@{#39749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -45 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +69 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +27 lines, -2 lines 0 comments Download
M src/js/regexp.js View 1 chunk +2 lines, -11 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 6 chunks +39 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Benedikt Meurer
Created Revert of [turbofan] ChangeFloat64ToTagged shouldn't canonicalize.
4 years, 2 months ago (2016-09-27 05:10:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365353006/1
4 years, 2 months ago (2016-09-27 05:10:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 05:10:47 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 05:11:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b68915b3b87ac6da9408a4d5d756cfe0440d8b
Cr-Commit-Position: refs/heads/master@{#39749}

Powered by Google App Engine
This is Rietveld 408576698