Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2365353002: Add 'WorkerGlobalScope::isSecureContext' (Closed)

Created:
4 years, 2 months ago by Mike West
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-worker-reviews_chromium.org, chromium-reviews, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, shimazu+worker_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add 'WorkerGlobalScope::isSecureContext' We shipped the 'Window' variant in [1] a ~year ago, with the promise that we'd totally come back and do the 'Worker' bit. *cough* So, here it is! [1]: https://chromium.googlesource.com/chromium/src/+/fd67eed6357b2a5487c13cc159b4e843a9c91aee BUG=534788, 649896 Committed: https://crrev.com/bd027238e7f3d3c8096c1a62e9063d8cbf5d8a80 Cr-Commit-Position: refs/heads/master@{#421810}

Patch Set 1 #

Total comments: 1

Patch Set 2 : webexposed #

Patch Set 3 : test #

Patch Set 4 : I hate webexposed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/secureContexts/authenticated_worker.https.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/secureContexts/resources/post-securecontext.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/secureContexts/resources/post-securecontext-shared.js View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/secureContexts/unauthenticated_worker.html View 1 chunk +44 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
Mike West
Hey Jochen, Philip! We shipped half of this feature a year ago, and I forgot ...
4 years, 2 months ago (2016-09-26 12:51:08 UTC) #4
foolip
lgtm, but a comment on the original thread would be nice, and something on chromestatus.com? ...
4 years, 2 months ago (2016-09-26 13:46:46 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-26 15:10:38 UTC) #8
Mike West
On 2016/09/26 at 13:46:46, foolip wrote: > lgtm, but a comment on the original thread ...
4 years, 2 months ago (2016-09-27 08:36:05 UTC) #9
Mike West
Thanks! I'll ping the thread with a note about my lack of followthrough.
4 years, 2 months ago (2016-09-27 08:36:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365353002/20001
4 years, 2 months ago (2016-09-28 11:49:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/301144)
4 years, 2 months ago (2016-09-28 12:54:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365353002/40001
4 years, 2 months ago (2016-09-29 09:20:38 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/301936)
4 years, 2 months ago (2016-09-29 10:49:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365353002/60001
4 years, 2 months ago (2016-09-29 12:19:18 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-29 14:06:46 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 14:08:41 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bd027238e7f3d3c8096c1a62e9063d8cbf5d8a80
Cr-Commit-Position: refs/heads/master@{#421810}

Powered by Google App Engine
This is Rietveld 408576698