Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3962)

Unified Diff: cc/tiles/image_manager.cc

Issue 2365303003: cc: Reorder TileManager shutdown and add debugging information. (Closed)
Patch Set: crash: update Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/image_manager.h ('k') | cc/tiles/tile_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/image_manager.cc
diff --git a/cc/tiles/image_manager.cc b/cc/tiles/image_manager.cc
index bec8ca2061ea084d92011d83ff288683883c92d1..04d4e61a9bbd3f9d43c97ac35ce5a0ce42c8efbb 100644
--- a/cc/tiles/image_manager.cc
+++ b/cc/tiles/image_manager.cc
@@ -11,14 +11,17 @@ ImageManager::~ImageManager() = default;
void ImageManager::SetImageDecodeController(ImageDecodeController* controller) {
// We can only switch from null to non-null and back.
- DCHECK(controller || controller_);
- DCHECK(!controller || !controller_);
+ // CHECK to debug crbug.com/650234.
+ CHECK(controller || controller_);
+ CHECK(!controller || !controller_);
if (!controller) {
SetPredecodeImages(std::vector<DrawImage>(),
ImageDecodeController::TracingInfo());
}
controller_ = controller;
+ // Debugging information for crbug.com/650234.
+ ++num_times_controller_was_set_;
}
void ImageManager::GetTasksForImagesAndRef(
@@ -41,7 +44,8 @@ void ImageManager::GetTasksForImagesAndRef(
}
void ImageManager::UnrefImages(const std::vector<DrawImage>& images) {
- DCHECK(controller_);
+ // Debugging information for crbug.com/650234.
+ CHECK(controller_) << num_times_controller_was_set_;
for (auto image : images)
controller_->UnrefImage(image);
}
« no previous file with comments | « cc/tiles/image_manager.h ('k') | cc/tiles/tile_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698