Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2365303003: cc: Reorder TileManager shutdown and add debugging information. (Closed)

Created:
4 years, 2 months ago by vmpstr
Modified:
4 years, 2 months ago
Reviewers:
ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Reorder TileManager shutdown and add debugging information. This patch changes the order of shutdown from clearing orphans then completing tasks to first complete the tasks then clean orphans, since task completion causes more orphans to be generated. Also, this adds debugging information to ImageManager to narrow down the time when crash in the referenced bug happens. R=ericrk@chromium.org BUG=650234 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/63faa3a635d7ad979c9fc30de93ee0957003586d Cr-Commit-Position: refs/heads/master@{#421261}

Patch Set 1 #

Patch Set 2 : crash: update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M cc/tiles/image_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/tiles/image_manager.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
vmpstr
Please take a look.
4 years, 2 months ago (2016-09-26 18:45:13 UTC) #2
ericrk
I like the ordering change! LGTM
4 years, 2 months ago (2016-09-26 21:43:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365303003/20001
4 years, 2 months ago (2016-09-26 22:50:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/284559)
4 years, 2 months ago (2016-09-26 23:50:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365303003/20001
4 years, 2 months ago (2016-09-26 23:54:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148609)
4 years, 2 months ago (2016-09-27 01:41:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365303003/20001
4 years, 2 months ago (2016-09-27 17:28:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 18:04:10 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:06:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63faa3a635d7ad979c9fc30de93ee0957003586d
Cr-Commit-Position: refs/heads/master@{#421261}

Powered by Google App Engine
This is Rietveld 408576698