IndexedDB: Have IDBCursor and IDBRequest explicitly break ref cycles

Source/modules/indexeddb/IDBAny.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 73 matching lines @@
         IDBObjectStoreType,
         IDBTransactionType,
         ScriptValueType,
         IntegerType,
         StringType,
         KeyPathType,
     };
 
     Type type() const { return m_type; }
     // Use type() to figure out which one of these you're allowed to call.
-    PassRefPtr<DOMStringList> domStringList();
-    PassRefPtr<IDBCursor> idbCursor();
-    PassRefPtr<IDBCursorWithValue> idbCursorWithValue();
-    PassRefPtr<IDBDatabase> idbDatabase();
-    PassRefPtr<IDBFactory> idbFactory();
-    PassRefPtr<IDBIndex> idbIndex();
-    PassRefPtr<IDBObjectStore> idbObjectStore();
-    PassRefPtr<IDBTransaction> idbTransaction();
+    DOMStringList* domStringList();

[jsbell, 2013/09/06 00:27:51]

This may seem unrelated, but without this the request->getResultCursor() call
churns the cursor's reference count, which ends up with recursing in the
cursor's deref().

Using PassRefPtr<> here is not necessary since these accessors never mint a new
RefPtr<>.
 

+    IDBCursor* idbCursor();
+    IDBCursorWithValue* idbCursorWithValue();
+    IDBDatabase* idbDatabase();
+    IDBFactory* idbFactory();
+    IDBIndex* idbIndex();
+    IDBObjectStore* idbObjectStore();
+    IDBTransaction* idbTransaction();
     const ScriptValue& scriptValue();
     int64_t integer();
     const String& string();
     const IDBKeyPath& keyPath() { return m_idbKeyPath; };
 
 private:
     explicit IDBAny(Type);
     explicit IDBAny(PassRefPtr<DOMStringList>);
     explicit IDBAny(PassRefPtr<IDBCursor>);
     explicit IDBAny(PassRefPtr<IDBCursorWithValue>);
@@ skipping 20 matching lines @@
     const RefPtr<IDBTransaction> m_idbTransaction;
     const IDBKeyPath m_idbKeyPath;
     const ScriptValue m_scriptValue;
     const String m_string;
     const int64_t m_integer;
 };
 
 } // namespace WebCore
 
 #endif // IDBAny_h