Support webview tag in component extension

chrome/renderer/extensions/dispatcher.cc

Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index ce2408f603efa9981090d4b2242f9c4b04652aef..c20611e4b9b56d444e9dce888ad88c3ee63b4005 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -479,8 +479,7 @@ void Dispatcher::WebKitInitialized() {
     InitOriginPermissions(extension);
   }
 
-  if (IsWithinPlatformApp())
-    EnableCustomElementWhiteList();
+  EnableCustomElementWhiteList();

[not at google - send to devlin, 2013/09/20 16:44:34]

could you guard this with the webview permission check?

[guohui, 2013/09/23 18:34:10]

But we don't have the extension ID here to check for webview perission.

And as commented by dominic, the only side effect is that webview "will have
HTMLElement as their interface instead of HTMLUnknownElement".

[not at google - send to devlin, 2013/09/23 20:59:12]

A few lines above we loop over the extensions; you could initialize the custom
element whitelist from within there.

[guohui, 2013/09/23 21:17:57]

but we only loop over "active" extensions above, and thus it will not work for
extensions iframed in webUI.

 
   is_webkit_initialized_ = true;
 }
@@ -1114,11 +1113,10 @@ void Dispatcher::DidCreateScriptContext(
     module_system->Require("windowControls");
   }
 
-  // Only platform apps support the <webview> tag, because the "webView" and
-  // "denyWebView" modules will affect the performance of DOM modifications
-  // (http://crbug.com/196453).
-  if (context_type == Feature::BLESSED_EXTENSION_CONTEXT &&
-      is_within_platform_app) {
+  // Currently only platform apps and whitelisted component extensions support
+  // the <webview> tag, because the "webView" and "denyWebView" modules will
+  // affect the performance of DOM modifications (http://crbug.com/196453).
+  if (context_type == Feature::BLESSED_EXTENSION_CONTEXT) {
     // Note: setting up the WebView class here, not the chrome.webview API.
     // The API will be automatically set up when first used.
     if (extension->HasAPIPermission(APIPermission::kWebView)) {
@@ -1252,8 +1250,7 @@ void Dispatcher::OnActivateExtension(const std::string& extension_id) {
                                      extension->url(),
                                      string16());
 
-    if (IsWithinPlatformApp())
-      EnableCustomElementWhiteList();
+    EnableCustomElementWhiteList();

[not at google - send to devlin, 2013/09/20 16:44:34]

likewise

[not at google - send to devlin, 2013/09/23 20:59:12]

... and here, we do know what the extension is.

[guohui, 2013/09/23 21:17:57]

yes i could add webview check here, though i think if we always call
EnableCustomElementWhiteList in WebkitInitialized above, then we don't need to
call it again here.

   }
 }