Avatar syncing for supervised users

chrome/browser/managed_mode/managed_user_registration_utility.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_USER_REGISTRATION_UTILITY_H_
 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_USER_REGISTRATION_UTILITY_H_
 
 #include <map>
 #include <string>
 
@@ skipping 13 matching lines @@
 class ManagedUserRefreshTokenFetcher;
 class ManagedUserRegistrationUtilityTest;
 class PrefService;
 
 namespace browser_sync {
 class DeviceInfo;
 }
 
 // Structure to store registration information.
 struct ManagedUserRegistrationInfo {
   explicit ManagedUserRegistrationInfo(const string16& name);

[Bernhard Bauer, 2013/09/05 13:15:33]

You should probably still initialize |avatar_index| to *some* value.

[ibra, 2013/09/05 13:28:38]

Wouldn't that make more sense once Chrome OS also supports avatar syncing, right
now we would have to send in a dummy value, WDYT? If you agree I can add a TODO
instead.

[Bernhard Bauer, 2013/09/05 14:09:47]

Well, right now you get an undefined value if the caller does not set one (like
on Chrome OS), which is what I would like to avoid.

You could use 0 or a dummy value; I would prefer a dummy value because you can
DCHECK in ManagedUserSyncService for its presence if you don't use the avatar
index (i.e. on Chrome OS), or for its absence if you do use it.

+  int avatar_index;
   string16 name;
   std::string master_key;
 };
 
 // Holds the state necessary for registering a new managed user with the
 // management server and associating it with its custodian. Each instance
 // of this class handles registering a single managed user and should not
 // be used afterwards.
 class ManagedUserRegistrationUtility {
  public:
@@ skipping 47 matching lines @@
 class ScopedTestingManagedUserRegistrationUtility {
  public:
   // Delegates ownership of the |instance| to ManagedUserRegistrationUtility.
   ScopedTestingManagedUserRegistrationUtility(
       ManagedUserRegistrationUtility* instance);
 
   ~ScopedTestingManagedUserRegistrationUtility();
 };
 
 #endif  // CHROME_BROWSER_MANAGED_MODE_MANAGED_USER_REGISTRATION_UTILITY_H_