Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2365283003: Make backend destructor public (Closed)

Created:
4 years, 2 months ago by Sarmad Hashmi
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make backend destructor public This allows Backend pointers to point to derived classes. BUG=648701 Committed: https://crrev.com/fb4bbebb606d40493cdc89baecb7139c6b7c8be4 Cr-Commit-Position: refs/heads/master@{#421221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_h.template View 2 chunks +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
dgozman
lgtm
4 years, 2 months ago (2016-09-26 16:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365283003/1
4 years, 2 months ago (2016-09-26 17:06:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286311)
4 years, 2 months ago (2016-09-26 18:34:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365283003/1
4 years, 2 months ago (2016-09-26 18:42:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286466)
4 years, 2 months ago (2016-09-26 20:25:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365283003/1
4 years, 2 months ago (2016-09-27 14:58:21 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 15:44:56 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 15:46:51 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb4bbebb606d40493cdc89baecb7139c6b7c8be4
Cr-Commit-Position: refs/heads/master@{#421221}

Powered by Google App Engine
This is Rietveld 408576698