Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: content/browser/renderer_host/render_process_host_impl.h

Issue 2365273004: Initial implementation for sharing field trial state (win) (Closed)
Patch Set: add feature logic for sharing field trials Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.h
diff --git a/content/browser/renderer_host/render_process_host_impl.h b/content/browser/renderer_host/render_process_host_impl.h
index aac8afa60c469e67337e8ded3fe2a9e2d5abfcf8..ff19355208796571d7597c4ad42eb563c2d36c37 100644
--- a/content/browser/renderer_host/render_process_host_impl.h
+++ b/content/browser/renderer_host/render_process_host_impl.h
@@ -356,14 +356,14 @@ class CONTENT_EXPORT RenderProcessHostImpl
// Generates a command line to be used to spawn a renderer and appends the
// results to |*command_line|.
- void AppendRendererCommandLine(base::CommandLine* command_line) const;
+ void AppendRendererCommandLine(base::CommandLine* command_line);
// Copies applicable command line switches from the given |browser_cmd| line
// flags to the output |renderer_cmd| line flags. Not all switches will be
// copied over.
void PropagateBrowserCommandLineToRenderer(
const base::CommandLine& browser_cmd,
- base::CommandLine* renderer_cmd) const;
+ base::CommandLine* renderer_cmd);
// Inspects the current object state and sets/removes background priority if
// appropriate. Should be called after any of the involved data members
@@ -587,6 +587,12 @@ class CONTENT_EXPORT RenderProcessHostImpl
// The memory allocator, if any, in which the renderer will write its metrics.
std::unique_ptr<base::SharedPersistentMemoryAllocator> metrics_allocator_;
+ // Anonymous shared memory segment to share with subprocess containing list of
+ // field trials (represented as a string).
+ // TODO(lawrencewu): Eventually remove this and use single shared memory
+ // object across processes.
+ std::unique_ptr<base::SharedMemory> field_trial_state_;
+
bool channel_connected_;
bool sent_render_process_ready_;

Powered by Google App Engine
This is Rietveld 408576698