Delete pre-MD code from OmniboxResultView

Delete pre-MD code from OmniboxResultView

BUG=648281
Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
Cr-Commit-Position: refs/heads/master@{#423690}

[Evan Stade, 2016-09-27 18:03:51]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:04:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:58:19]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-27 21:10:49]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 21:11:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-09-27 21:16:06]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 21:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 21:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 21:27:24]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Evan Stade, 2016-09-28 22:44:49]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 22:45:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 22:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 22:55:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-09-29 17:36:19]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 17:36:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 17:50:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 17:50:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-09-30 00:24:03]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 00:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 01:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 01:11:21]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-09-30 18:12:27]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-09-30 18:12:28]

doesn't seem mobile actually uses omnibox icons any more

[Evan Stade, 2016-10-03 20:00:40]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 20:52:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 20:52:57]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-10-04 07:56:15]

On 2016/09/30 18:12:28, Evan Stade wrote:
> doesn't seem mobile actually uses omnibox icons any more

Will try to get to this Tue 10/4

[Peter Kasting, 2016-10-06 04:45:36]

LGTM

https://codereview.chromium.org/2365263006/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/options/network_config_view.cc (right):

https://codereview.chromium.org/2365263006/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/options/network_config_view.cc:319: Init();
Nit: I don't know that Init() buys much anymore now that it's called just once
and there's almost nothing else to this class.  I'd inline it here.

https://codereview.chromium.org/2365263006/diff/120001/components/toolbar/too...
File components/toolbar/toolbar_model_impl.cc (right):

https://codereview.chromium.org/2365263006/diff/120001/components/toolbar/too...
components/toolbar/toolbar_model_impl.cc:73: #if !defined(OS_ANDROID) &&
!defined(OS_IOS)
The fact that this #if is still here makes me worry about whether mobile could
still reach the GetIcon() code above before this patch.

[Evan Stade, 2016-10-06 15:16:37]

https://codereview.chromium.org/2365263006/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/options/network_config_view.cc (right):

https://codereview.chromium.org/2365263006/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/options/network_config_view.cc:319: Init();
On 2016/10/06 04:45:36, Peter Kasting (OOO Oct. 6-9) wrote:
> Nit: I don't know that Init() buys much anymore now that it's called just once
> and there's almost nothing else to this class.  I'd inline it here.

Done.

https://codereview.chromium.org/2365263006/diff/120001/components/toolbar/too...
File components/toolbar/toolbar_model_impl.cc (right):

https://codereview.chromium.org/2365263006/diff/120001/components/toolbar/too...
components/toolbar/toolbar_model_impl.cc:73: #if !defined(OS_ANDROID) &&
!defined(OS_IOS)
On 2016/10/06 04:45:36, Peter Kasting (OOO Oct. 6-9) wrote:
> The fact that this #if is still here makes me worry about whether mobile could
> still reach the GetIcon() code above before this patch.

yea, I wasn't sure either but I got green try runs. I think they just stopped
calling GetIcon at some point, but still use at least some of the rest of this
file.

[Evan Stade, 2016-10-06 15:19:57]

estade@chromium.org changed reviewers:
+ blundell@chromium.org, sky@chromium.org

[Evan Stade, 2016-10-06 15:19:58]

+sky for
  chrome/app/theme/theme_resources.grd
  chrome/browser/chromeos/options/*
  chrome/browser/extensions/extension_context_menu_model.cc

+blundell for
  components/resources (since it's all omnibox stuff pkasting should probably be
an owner of it, but he currently he is not)

[Evan Stade, 2016-10-06 15:20:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:20:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 15:35:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 15:35:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[blundell, 2016-10-06 16:41:52]

//components/resources rubberstamp lgtm

[Evan Stade, 2016-10-06 16:44:36]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 16:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:35:02]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-06 21:18:56]

LGTM

https://codereview.chromium.org/2365263006/diff/160001/chrome/browser/extensi...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/2365263006/diff/160001/chrome/browser/extensi...
chrome/browser/extensions/extension_context_menu_model.cc:333:
gfx::Image(gfx::CreateVectorIcon(gfx::VectorIconId::BUSINESS, 16,
Business, eh? I'm assuming this is right.

[Evan Stade, 2016-10-06 21:27:10]

https://codereview.chromium.org/2365263006/diff/160001/chrome/browser/extensi...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/2365263006/diff/160001/chrome/browser/extensi...
chrome/browser/extensions/extension_context_menu_model.cc:333:
gfx::Image(gfx::CreateVectorIcon(gfx::VectorIconId::BUSINESS, 16,
On 2016/10/06 21:18:55, sky wrote:
> Business, eh? I'm assuming this is right.

yea, it looks like a small cluster of office buildings.

[Evan Stade, 2016-10-06 21:27:15]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-10-06 21:27:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2365263006/#ps160001
(title: "update references to constant (merge resolution)")

[commit-bot: I haz the power, 2016-10-06 21:27:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 21:35:38]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-10-06 21:38:11]

Description was changed from

==========
Delete pre-MD code from OmniboxResultView

BUG=648281
==========

to

==========
Delete pre-MD code from OmniboxResultView

BUG=648281

Committed: https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
Cr-Commit-Position: refs/heads/master@{#423690}
==========

[commit-bot: I haz the power, 2016-10-06 21:38:13]

Patchset 9 (id:??) landed as
https://crrev.com/255d6d6d2bbc0e8715ad0985d239897f80a4b707
Cr-Commit-Position: refs/heads/master@{#423690}

[sdefresne, 2016-10-07 08:07:58]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2399333002/ by sdefresne@chromium.org.

The reason for reverting is: The downstream Chrome on iOS code has never been
ported to the new vector icon and still use MD raster icon. This CL breaks
Chrome on iOS downstream (due to missing resources and removal of GetIcon()
method)..

[blundell, 2016-10-07 08:40:05]

On 2016/10/07 08:07:58, sdefresne wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/2399333002/ by mailto:sdefresne@chromium.org.
> 
> The reason for reverting is: The downstream Chrome on iOS code has never been
> ported to the new vector icon and still use MD raster icon. This CL breaks
> Chrome on iOS downstream (due to missing resources and removal of GetIcon()
> method)..

Whoops, I probably should have realized that that might be the case.