Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2365263005: Turn off FLAG_lazy_inner_functions (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn off FLAG_lazy_inner_functions 1) To get proper test coverage for the flag turned off 2) We need more scope analysis in the PreParser to not disable optimizations for some common cases (inner function "var i" shadowing outer function vars). R=verwaest@chromium.org BUG= Committed: https://crrev.com/cbb3d91f306cd28966986564f8e5cc7cdc2cdd78 Cr-Commit-Position: refs/heads/master@{#39768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-27 12:17:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365263005/1
4 years, 2 months ago (2016-09-27 12:20:23 UTC) #3
Benedikt Meurer
Thanks, LGTM.
4 years, 2 months ago (2016-09-27 12:21:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 12:47:54 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:48:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbb3d91f306cd28966986564f8e5cc7cdc2cdd78
Cr-Commit-Position: refs/heads/master@{#39768}

Powered by Google App Engine
This is Rietveld 408576698