Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2365263004: Make (almost) all SpdySessions secure in unittests. (Closed)

Created:
4 years, 2 months ago by Bence
Modified:
4 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make (almost) all SpdySessions secure in unittests. BUG=624073 Committed: https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc Cr-Commit-Position: refs/heads/master@{#420936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -256 lines) Patch
M net/http/http_network_transaction_unittest.cc View 12 chunks +19 lines, -47 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 16 chunks +50 lines, -36 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 79 chunks +214 lines, -146 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 19 chunks +41 lines, -16 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 2 months ago (2016-09-26 17:50:44 UTC) #6
Ryan Hamilton
lgtm woot!
4 years, 2 months ago (2016-09-26 17:57:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365263004/1
4 years, 2 months ago (2016-09-26 18:09:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 18:17:40 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 18:20:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/032658babe56835d8a5fafc8f1d45f4c6d4cd9dc
Cr-Commit-Position: refs/heads/master@{#420936}

Powered by Google App Engine
This is Rietveld 408576698