third_party/WebKit/Source/modules/accessibility/AXObject.cpp - Issue 2365263003: Implement NSAccessibilityScrollToVisibleAction on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2365263003: Implement NSAccessibilityScrollToVisibleAction on Mac (Closed)

Patch Set: Fix endless loop in AXObject::scrollToMakeVisibleWithSubFocus Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

index 3167659f49f35e6729150c58318bc73291de8ec4..ac2b6a23433a5783ce68f9f3dd420475e86f937d 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

@@ -1516,7 +1516,7 @@ static int computeBestScrollOffset(int currentScrollOffset, int subfocusMin, int

void AXObject::scrollToMakeVisibleWithSubFocus(const IntRect& subfocus) const

{

// Search up the parent chain until we find the first one that's scrollable.

- AXObject* scrollParent = parentObject();

+ const AXObject* scrollParent = parentObject() ? parentObject() : this;

ScrollableArea* scrollableArea = 0;

while (scrollParent) {

scrollableArea = scrollParent->getScrollableAreaIfScrollable();

« no previous file with comments | « content/renderer/accessibility/render_accessibility_impl.cc ('k') | no next file » | no next file with comments »