Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/code-stub-assembler.h

Issue 2365223003: Revert of [compiler] Properly guard the speculative optimizations for instanceof. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index bd975faf4e3982c260be2e2be6ee949d9e1a586b..25299b5503ca394048c02d3d3ea6f0333c854ccd 100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -26,24 +26,6 @@
// from a compiler directory OWNER).
class CodeStubAssembler : public compiler::CodeAssembler {
public:
- class VectorSlotPair final {
- public:
- VectorSlotPair() : vector_(nullptr), index_(nullptr) {}
- VectorSlotPair(compiler::Node* vector, compiler::Node* index)
- : vector_(vector), index_(index) {
- DCHECK_NOT_NULL(vector);
- DCHECK_NOT_NULL(index);
- }
-
- bool IsValid() const { return vector_ != nullptr; }
- compiler::Node* vector() const { return vector_; }
- compiler::Node* index() const { return index_; }
-
- private:
- compiler::Node* const vector_;
- compiler::Node* const index_;
- };
-
// Create with CallStub linkage.
// |result_size| specifies the number of results returned by the stub.
// TODO(rmcilroy): move result_size to the CallInterfaceDescriptor.
@@ -645,9 +627,9 @@
// Instanceof helpers.
// ES6 section 7.3.19 OrdinaryHasInstance (C, O)
- compiler::Node* OrdinaryHasInstance(
- compiler::Node* context, compiler::Node* callable, compiler::Node* object,
- VectorSlotPair feedback = VectorSlotPair());
+ compiler::Node* OrdinaryHasInstance(compiler::Node* context,
+ compiler::Node* callable,
+ compiler::Node* object);
// LoadIC helpers.
struct LoadICParameters {
« no previous file with comments | « src/ast/ast.cc ('k') | src/code-stub-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698