Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2365223003: Revert of [compiler] Properly guard the speculative optimizations for instanceof. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 3318 matching lines...) Expand 10 before | Expand all | Expand 10 after
3329 EmitHasProperty(); 3329 EmitHasProperty();
3330 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL); 3330 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);
3331 __ cmp(eax, isolate()->factory()->true_value()); 3331 __ cmp(eax, isolate()->factory()->true_value());
3332 Split(equal, if_true, if_false, fall_through); 3332 Split(equal, if_true, if_false, fall_through);
3333 break; 3333 break;
3334 3334
3335 case Token::INSTANCEOF: { 3335 case Token::INSTANCEOF: {
3336 VisitForAccumulatorValue(expr->right()); 3336 VisitForAccumulatorValue(expr->right());
3337 SetExpressionPosition(expr); 3337 SetExpressionPosition(expr);
3338 PopOperand(edx); 3338 PopOperand(edx);
3339 __ EmitLoadTypeFeedbackVector(ebx); 3339 InstanceOfStub stub(isolate());
3340 __ mov(edi, Immediate(SlotToIndex(expr->CompareOperationFeedbackSlot())));
3341 InstanceOfWithFeedbackStub stub(isolate());
3342 __ CallStub(&stub); 3340 __ CallStub(&stub);
3343 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL); 3341 PrepareForBailoutBeforeSplit(expr, false, NULL, NULL);
3344 __ cmp(eax, isolate()->factory()->true_value()); 3342 __ cmp(eax, isolate()->factory()->true_value());
3345 Split(equal, if_true, if_false, fall_through); 3343 Split(equal, if_true, if_false, fall_through);
3346 break; 3344 break;
3347 } 3345 }
3348 3346
3349 default: { 3347 default: {
3350 VisitForAccumulatorValue(expr->right()); 3348 VisitForAccumulatorValue(expr->right());
3351 SetExpressionPosition(expr); 3349 SetExpressionPosition(expr);
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
3587 isolate->builtins()->OnStackReplacement()->entry(), 3585 isolate->builtins()->OnStackReplacement()->entry(),
3588 Assembler::target_address_at(call_target_address, unoptimized_code)); 3586 Assembler::target_address_at(call_target_address, unoptimized_code));
3589 return ON_STACK_REPLACEMENT; 3587 return ON_STACK_REPLACEMENT;
3590 } 3588 }
3591 3589
3592 3590
3593 } // namespace internal 3591 } // namespace internal
3594 } // namespace v8 3592 } // namespace v8
3595 3593
3596 #endif // V8_TARGET_ARCH_IA32 3594 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/full-codegen.h ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698