Remove content dependency from remoting/host

Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to
build. This change removes net::IPEndPoint from IPC messages
used by the host, so it no longer needs to depend on content.

Committed: https://crrev.com/f684dd192b64186de1eb04d819af6db0dca3e503
Cr-Commit-Position: refs/heads/master@{#421665}

[Sergey Ulanov, 2016-09-25 22:25:26]

The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-25 22:25:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-25 22:34:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-25 22:34:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Sergey Ulanov, 2016-09-25 23:04:22]

The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-25 23:04:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-25 23:22:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-25 23:22:58]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Sergey Ulanov, 2016-09-26 17:29:17]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2016-09-26 17:29:23]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2016-09-26 17:34:39]

Description was changed from

==========
Remove content dependency from remoting/host
==========

to

==========
Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to 
build. This change removes net::IPEndPoint from IPC messages 
used by the host, so it no longer needs to depend on content.
==========

[Sergey Ulanov, 2016-09-26 17:37:32]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org, rsesek@chromium.org

[Sergey Ulanov, 2016-09-26 17:37:32]

Joe, please review this change.
Robert, please approve the change in chromoting_messages.h

[Sergey Ulanov, 2016-09-26 17:37:58]

The CQ bit was checked by sergeyu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 17:38:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-09-26 18:12:23]

lgtm

[commit-bot: I haz the power, 2016-09-26 18:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:27:45]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Robert Sesek, 2016-09-26 22:12:34]

I don't think this is quite equivalent to the ParamTraits version, which checks
sizes and the validity of the address:
https://cs.chromium.org/chromium/src/content/public/common/common_param_trait....

Looking at the net::IPAddress ctor, it blindly assumes the bytes vector is sized
correctly and well-formed.

[Sergey Ulanov, 2016-09-26 23:29:44]

On 2016/09/26 22:12:34, Robert Sesek wrote:
> I don't think this is quite equivalent to the ParamTraits version, which
checks
> sizes and the validity of the address:
>
https://cs.chromium.org/chromium/src/content/public/common/common_param_trait....
> 
> Looking at the net::IPAddress ctor, it blindly assumes the bytes vector is
sized
> correctly and well-formed.

net::IPAddress can be created with a vector of any size, but it treats any
address that is not 4 or 16 bytes as an invalid address, see
https://cs.chromium.org/chromium/src/net/base/ip_address.cc?rcl=1474903310&l=185
. So I don't think any extra checks are really necessary there.
But I added them anyway now.

[Robert Sesek, 2016-09-27 20:03:51]

LGTM

[Sergey Ulanov, 2016-09-27 20:24:45]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-27 20:24:45]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2365213002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2016-09-27 20:25:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 20:25:22]

CQ cannot get SignCLA result. Please try later.

[Sergey Ulanov, 2016-09-27 22:29:29]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 22:40:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 22:40:06]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Sergey Ulanov, 2016-09-28 21:43:39]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-09-28 21:43:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2365213002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-09-28 21:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 22:38:21]

Description was changed from

==========
Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to 
build. This change removes net::IPEndPoint from IPC messages 
used by the host, so it no longer needs to depend on content.
==========

to

==========
Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to 
build. This change removes net::IPEndPoint from IPC messages 
used by the host, so it no longer needs to depend on content.
==========

[commit-bot: I haz the power, 2016-09-28 22:38:22]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-09-28 22:40:50]

Description was changed from

==========
Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to 
build. This change removes net::IPEndPoint from IPC messages 
used by the host, so it no longer needs to depend on content.
==========

to

==========
Remove content dependency from remoting/host

//content/public/common dependency was added in remoting/host
for IPC::ParamTraits<net::IPEndPoint>. That dependency pulls
blink, which means that blink had to be built when building
remoting_unittests and so it was taking way too much time to
build. This change removes net::IPEndPoint from IPC messages
used by the host, so it no longer needs to depend on content.

Committed: https://crrev.com/f684dd192b64186de1eb04d819af6db0dca3e503
Cr-Commit-Position: refs/heads/master@{#421665}
==========

[commit-bot: I haz the power, 2016-09-28 22:40:51]

Patchset 3 (id:??) landed as
https://crrev.com/f684dd192b64186de1eb04d819af6db0dca3e503
Cr-Commit-Position: refs/heads/master@{#421665}