Move async/await JS support code out of experimental natives

Move async/await JS support code out of experimental natives

The file formerly known as src/js/harmony-async-await.js does not
expose anything directly to JavaScript code; it just makes a few
functions available on the native context for the parser desugaring
to expand into. Experimental natives have various issues with
larger amounts of code, so this patch moves the JS builtins to
support async functions out of experimental natives and into the
core snapshot. The change would be done eventually anyway, but this
patch does it before removing the flag to support shipping the
feature while avoiding the pitfalls of experimental natives.

Drive by cleanup: remove more unused functions from the whitelist for experimental natives.

BUG=v8:5427, v8:4483
Committed: https://crrev.com/13b8a1238b4d08d91938b3fea6bc25a34958ac78
Cr-Commit-Position: refs/heads/master@{#39706}

[Dan Ehrenberg, 2016-09-24 04:16:58]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 04:17:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 04:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 04:21:17]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Dan Ehrenberg, 2016-09-24 04:22:22]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 04:22:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-24 04:24:18]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 04:24:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 04:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 04:37:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Dan Ehrenberg, 2016-09-24 05:02:30]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 05:02:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-09-24 05:03:39]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 05:03:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 05:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 05:31:20]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2016-09-24 14:42:13]

littledan@chromium.org changed reviewers:
+ gsathya@chromium.org, yangguo@chromium.org

[Dan Ehrenberg, 2016-09-24 14:42:14]

I have verified interactively that this patch gets rid of the TSAN failures that
come from shipping async functions, as documented in
https://bugs.chromium.org/p/v8/issues/detail?id=5427 . However, the tests there
still fail if you pass --harmony. This change isn't a short-term workaround,
just changing the structure of the code slightly sooner than I previously
expected in the course of shipping the feature. PTAL.

[gsathya, 2016-09-24 15:04:49]

https://codereview.chromium.org/2365123002/diff/80001/src/js/prologue.js
File src/js/prologue.js (left):

https://codereview.chromium.org/2365123002/diff/80001/src/js/prologue.js#oldc...
src/js/prologue.js:207: "RegExpSubclassTest",
These RegExp changes seem unrelated to this patch right?

[gsathya, 2016-09-24 15:06:04]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org

[gsathya, 2016-09-24 15:06:05]

+adam, since i don't know a whole about the mechanics of --harmony

[Dan Ehrenberg, 2016-09-24 15:06:15]

Description was changed from

==========
Move async/await JS support code out of experimental natives

The file formerly known as src/js/harmony-async-await.js does not
expose anything directly to JavaScript code; it just makes a few
functions available on the native context for the parser desugaring
to expand into. Experimental natives have various issues with
larger amounts of code, so this patch moves the JS builtins to
support async functions out of experimental natives and into the
core snapshot. The change would be done eventually anyway, but this
patch does it before removing the flag to support shipping the
feature while avoiding the pitfalls of experimental natives.

BUG=v8:5427,v8:4483
==========

to

==========
Move async/await JS support code out of experimental natives

The file formerly known as src/js/harmony-async-await.js does not
expose anything directly to JavaScript code; it just makes a few
functions available on the native context for the parser desugaring
to expand into. Experimental natives have various issues with
larger amounts of code, so this patch moves the JS builtins to
support async functions out of experimental natives and into the
core snapshot. The change would be done eventually anyway, but this
patch does it before removing the flag to support shipping the
feature while avoiding the pitfalls of experimental natives.

Drive by cleanup: remove more unused functions from the whitelist for
experimental natives.

BUG=v8:5427,v8:4483
==========

[Dan Ehrenberg, 2016-09-24 15:06:15]

littledan@chromium.org changed reviewers:
- adamk@chromium.org

[Dan Ehrenberg, 2016-09-24 15:07:01]

littledan@chromium.org changed reviewers:
+ adamk@chromium.org

[Dan Ehrenberg, 2016-09-24 15:07:02]

https://codereview.chromium.org/2365123002/diff/80001/src/js/prologue.js
File src/js/prologue.js (left):

https://codereview.chromium.org/2365123002/diff/80001/src/js/prologue.js#oldc...
src/js/prologue.js:207: "RegExpSubclassTest",
On 2016/09/24 at 15:04:49, gsathya wrote:
> These RegExp changes seem unrelated to this patch right?

Yes, a drive by cleanup. I noted it in the commit message.

[gsathya, 2016-09-24 15:10:38]

lgtm

[Dan Ehrenberg, 2016-09-24 15:11:05]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-09-24 15:11:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 15:15:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-24 15:15:27]

Description was changed from

==========
Move async/await JS support code out of experimental natives

The file formerly known as src/js/harmony-async-await.js does not
expose anything directly to JavaScript code; it just makes a few
functions available on the native context for the parser desugaring
to expand into. Experimental natives have various issues with
larger amounts of code, so this patch moves the JS builtins to
support async functions out of experimental natives and into the
core snapshot. The change would be done eventually anyway, but this
patch does it before removing the flag to support shipping the
feature while avoiding the pitfalls of experimental natives.

Drive by cleanup: remove more unused functions from the whitelist for
experimental natives.

BUG=v8:5427,v8:4483
==========

to

==========
Move async/await JS support code out of experimental natives

The file formerly known as src/js/harmony-async-await.js does not
expose anything directly to JavaScript code; it just makes a few
functions available on the native context for the parser desugaring
to expand into. Experimental natives have various issues with
larger amounts of code, so this patch moves the JS builtins to
support async functions out of experimental natives and into the
core snapshot. The change would be done eventually anyway, but this
patch does it before removing the flag to support shipping the
feature while avoiding the pitfalls of experimental natives.

Drive by cleanup: remove more unused functions from the whitelist for
experimental natives.

BUG=v8:5427,v8:4483

Committed: https://crrev.com/13b8a1238b4d08d91938b3fea6bc25a34958ac78
Cr-Commit-Position: refs/heads/master@{#39706}
==========

[commit-bot: I haz the power, 2016-09-24 15:15:28]

Patchset 5 (id:??) landed as
https://crrev.com/13b8a1238b4d08d91938b3fea6bc25a34958ac78
Cr-Commit-Position: refs/heads/master@{#39706}