Issue 23651014: Merge "[Resource Timing] Fix potential double free problem"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23651014: Merge "[Resource Timing] Fix potential double free problem" (Closed)

Created:
7 years, 3 months ago by Nate Chapin

Modified:
7 years, 3 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/1599/

Visibility:
Public.

More Reviews

Description

Merge "[Resource Timing] Fix potential double free problem" Currently, ResourceTimingInfoMap in ResourceFetcher releases a ResourceTimingInfo after a resource is reported. If when blink is in reporting a resource entry, which lead to buffer full and immediately invoke "window.stop()" as callback, it will dive into ResourceFetcher::didLoadResource again, and release the memory in a nested. After that,the outer double free the memory as it just report the entry. This patch remove ResourceTiming from map ealier and prevent the double free case. Contributed by lifeasageek@gmail.com and pan.deng@intel.com BUG=286414 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157836

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/loader/cache/ResourceFetcher.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r157836.

Expand Messages | Collapse Messages