Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 23651010: Fix getComputedStyle background-position to output calc values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 23651010: Fix getComputedStyle background-position to output calc values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test and cleanup the patch Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index b49a941ce4405d9ff3f96b9abd5a2da0542dc0f7..421517bab2753823897db00388272ff9a8d9192f 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -564,7 +564,7 @@ static PassRefPtr<CSSPrimitiveValue> zoomAdjustedPixelValueForLength(const Lengt

{

if (length.isFixed())

return zoomAdjustedPixelValue(length.value(), style);

- return cssValuePool().createValue(length);

+ return cssValuePool().createValue(length, style);

}

static PassRefPtr<CSSValue> valueForReflection(const StyleReflection* reflection, const RenderStyle* style)

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-position-calc-expected.txt ('k') | no next file » | no next file with comments »