Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2365093002: Remove DownloadProcessService code path (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
Ted C, jam
CC:
chromium-reviews, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DownloadProcessService code path Chrome now uses the browser process for background download resumption. We don't need a separate process for this, remove the code. TBR=palmer@chromium.org Committed: https://crrev.com/de2fded6c79ab146307d808a5b5a18dea7e339df Cr-Commit-Position: refs/heads/master@{#423737}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -252 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 1 chunk +0 lines, -11 lines 0 comments Download
M content/app/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/app/android/download_main.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/app/content_main_runner.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/android/child_process_launcher_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 3 chunks +0 lines, -45 lines 0 comments Download
M content/public/android/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D content/public/android/java/res/values/ids.xml View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java View 1 3 chunks +0 lines, -7 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/app/DownloadProcessService.java View 1 chunk +0 lines, -78 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 5 chunks +0 lines, -47 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/IChildProcessCallback.aidl View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qinmin
PTAL
4 years, 2 months ago (2016-09-24 00:05:11 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-09-26 20:15:34 UTC) #3
qinmin
+jam as sievers@ is leaving
4 years, 2 months ago (2016-10-05 21:12:19 UTC) #5
jam
On 2016/10/05 21:12:19, qinmin wrote: > +jam as sievers@ is leaving I'm ignoring content/browser/android, content/public/android ...
4 years, 2 months ago (2016-10-05 22:57:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2365093002/20001
4 years, 2 months ago (2016-10-06 21:55:19 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 23:38:22 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:41:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de2fded6c79ab146307d808a5b5a18dea7e339df
Cr-Commit-Position: refs/heads/master@{#423737}

Powered by Google App Engine
This is Rietveld 408576698