Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_box.h

Issue 2365083002: Make NGFragment to own NGPhysicalFragment (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_box.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_box.h b/third_party/WebKit/Source/core/layout/ng/ng_box.h
index c7fe209635792de084ca0d959eeaf56e4c09370a..b1532148ad25f9e009b43c2c1353a58b7816b173 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_box.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_box.h
@@ -27,11 +27,10 @@ class CORE_EXPORT NGBox final : public GarbageCollectedFinalized<NGBox> {
explicit NGBox(ComputedStyle*);
// Returns true when done; when this function returns false, it has to be
- // called again. The out parameter will only be set when this function
- // returns true. The same constraint space has to be passed each time.
+ // called again. The same constraint space has to be passed each time.
// TODO(layout-ng): Should we have a StartLayout function to avoid passing
// the same space for each Layout iteration?
- bool Layout(const NGConstraintSpace*, NGFragment**);
+ bool Layout(const NGConstraintSpace*);
const ComputedStyle* Style() const;
NGBox* NextSibling();
@@ -41,6 +40,8 @@ class CORE_EXPORT NGBox final : public GarbageCollectedFinalized<NGBox> {
void SetNextSibling(NGBox*);
void SetFirstChild(NGBox*);
+ NGFragment* Fragment() { return fragment_; }
+
DEFINE_INLINE_VIRTUAL_TRACE() {
visitor->trace(algorithm_);
visitor->trace(fragment_);
@@ -63,7 +64,7 @@ class CORE_EXPORT NGBox final : public GarbageCollectedFinalized<NGBox> {
Member<NGBox> next_sibling_;
Member<NGBox> first_child_;
Member<NGBlockLayoutAlgorithm> algorithm_;
- Member<NGPhysicalFragment> fragment_;
+ Member<NGFragment> fragment_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698