Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2365053003: fix #27421, DDC did not generate implicit super calls in some cases (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27421, DDC did not generate implicit super calls in some cases this would happen when there was a chain of implicit super calls, leading to an implicit super with field initializers R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1129d3d121095d2346df9569d0c81e136e10930f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -21 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 11 chunks +22 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 11 chunks +22 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 11 chunks +22 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 11 chunks +22 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 4 chunks +4 lines, -5 lines 0 comments Download
A + pkg/dev_compiler/test/codegen/language/implicit_super_constructor_test.dart View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
4 years, 3 months ago (2016-09-23 23:49:19 UTC) #2
vsm
lgtm
4 years, 3 months ago (2016-09-23 23:55:05 UTC) #4
Jennifer Messerly
4 years, 3 months ago (2016-09-24 00:06:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1129d3d121095d2346df9569d0c81e136e10930f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698