Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 2365053002: Notify ServiceWorkerContextWatcher about routing ids of ServiceWorkerVersion and their updates. (Closed)
Patch Set: live updates Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index d787d5c1d9e71227ef5df1d4b66fd1540badb902..3803a44e6c64130440bcf36c2cd3b992752922b9 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -563,10 +563,10 @@ void ServiceWorkerContextCore::AddLiveVersion(ServiceWorkerVersion* version) {
live_versions_[version->version_id()] = version;
version->AddListener(this);
if (observer_list_.get()) {
+ ServiceWorkerVersionInfo version_info = version->GetInfo();
observer_list_->Notify(FROM_HERE,
&ServiceWorkerContextObserver::OnNewLiveVersion,
- version->version_id(), version->registration_id(),
- version->script_url());
+ version_info);
}
}
@@ -748,6 +748,16 @@ void ServiceWorkerContextCore::OnVersionStateChanged(
version->version_id(), version->status());
}
+void ServiceWorkerContextCore::OnRoutingIdsChanged(
+ ServiceWorkerVersion* version) {
+ if (!observer_list_ || !version->embedded_worker())
+ return;
+ observer_list_->Notify(
+ FROM_HERE, &ServiceWorkerContextObserver::OnVersionRoutingIdsChanged,
horo 2016/09/26 01:30:05 OnVersionDevToolsRoutingIdChanged
dgozman 2016/09/26 15:49:12 Done.
+ version->version_id(), version->embedded_worker()->process_id(),
+ version->embedded_worker()->worker_devtools_agent_route_id());
+}
+
void ServiceWorkerContextCore::OnMainScriptHttpResponseInfoSet(
ServiceWorkerVersion* version) {
if (!observer_list_)

Powered by Google App Engine
This is Rietveld 408576698