Enable --git-cache-dir option in chromite/cbuildbot.

Enable --git-cache-dir option in chromite/cbuildbot.

Run chromite/cbuildbot with --git-cache-dir='/b/cros_git_cache'. This
allows repo sync to bootstrap empty projects from git-cache instead of
fetching directly from GoB.

Also, track Chromite branch version in config for use in feature flag
evaluation.

BUG=chromium:632203
TEST=expectations

Committed: https://chromium.googlesource.com/chromium/tools/build/+/20f18fa6ef3826733e8629099b9403b6ccbdff8b

[nxia1, 2016-09-23 20:37:41]

nxia@google.com changed reviewers:
+ nxia@google.com

[nxia1, 2016-09-23 20:37:42]

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/config.py (right):

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/config.py:119:
git_cache_min_branch_version = Single(int, empty_val=8744),
Looked into branch stabilize-8798.B and factory-reef-8811.B, they don't support
--git-cache-dir yet. I think we can just disable supports_git_cache for tryjobs
for now. When we get a right git_cache_min_branch_version, we can enable the
git-cache on tryjobs?

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
File scripts/slave/recipes/cros/cbuildbot_tryjob.py (left):

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:192:
cbb_extra_args='["--timeout", "14400", "--remote-trybot",'
why are we removing this cbb_extra_args test?

[dnj, 2016-09-23 21:15:18]

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromite/config.py (right):

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromite/config.py:119:
git_cache_min_branch_version = Single(int, empty_val=8744),
On 2016/09/23 20:37:41, nxia1 wrote:
> Looked into branch stabilize-8798.B and factory-reef-8811.B, they don't
support
> --git-cache-dir yet. I think we can just disable supports_git_cache for
tryjobs
> for now. When we get a right git_cache_min_branch_version, we can enable the
> git-cache on tryjobs?

Well, ToT right now is pushing 8829, so how about we go with that?

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
File scripts/slave/recipes/cros/cbuildbot_tryjob.py (left):

https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
scripts/slave/recipes/cros/cbuildbot_tryjob.py:192:
cbb_extra_args='["--timeout", "14400", "--remote-trybot",'
On 2016/09/23 20:37:41, nxia1 wrote:
> why are we removing this cbb_extra_args test? 

Do we actually use this for BuildBucket still? I thought we were loading params
straight from BuildBucket param dict. Either way you're right, doesn't belong in
this CL.

[nxia1, 2016-09-23 21:42:53]

On 2016/09/23 21:15:18, dnj wrote:
>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
> File scripts/slave/recipe_modules/chromite/config.py (right):
> 
>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
> scripts/slave/recipe_modules/chromite/config.py:119:
> git_cache_min_branch_version = Single(int, empty_val=8744),
> On 2016/09/23 20:37:41, nxia1 wrote:
> > Looked into branch stabilize-8798.B and factory-reef-8811.B, they don't
> support
> > --git-cache-dir yet. I think we can just disable supports_git_cache for
> tryjobs
> > for now. When we get a right git_cache_min_branch_version, we can enable the
> > git-cache on tryjobs?
> 
> Well, ToT right now is pushing 8829, so how about we go with that?

8829 should be good. Let's set it as the default min_branch_version.


>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
> File scripts/slave/recipes/cros/cbuildbot_tryjob.py (left):
> 
>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipes/cros/...
> scripts/slave/recipes/cros/cbuildbot_tryjob.py:192:
> cbb_extra_args='["--timeout", "14400", "--remote-trybot",'
> On 2016/09/23 20:37:41, nxia1 wrote:
> > why are we removing this cbb_extra_args test? 
> 
> Do we actually use this for BuildBucket still? I thought we were loading
params
> straight from BuildBucket param dict. Either way you're right, doesn't belong
in
> this CL.

[dnj, 2016-09-23 21:57:26]

>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
> > scripts/slave/recipe_modules/chromite/config.py:119:
> > git_cache_min_branch_version = Single(int, empty_val=8744),
> > On 2016/09/23 20:37:41, nxia1 wrote:
> > > Looked into branch stabilize-8798.B and factory-reef-8811.B, they don't
> > support
> > > --git-cache-dir yet. I think we can just disable supports_git_cache for
> > tryjobs
> > > for now. When we get a right git_cache_min_branch_version, we can enable
the
> > > git-cache on tryjobs?
> > 
> > Well, ToT right now is pushing 8829, so how about we go with that?
> 
> 8829 should be good. Let's set it as the default min_branch_version.

Done.

For the record, it's good to reply to the code review comment when possible
rather than the text at the bottom. This keeps comments about code local to
their location in the code.

[nxia1, 2016-09-23 23:55:11]

On 2016/09/23 21:57:26, dnj wrote:
> >
>
https://codereview.chromium.org/2365023002/diff/1/scripts/slave/recipe_module...
> > > scripts/slave/recipe_modules/chromite/config.py:119:
> > > git_cache_min_branch_version = Single(int, empty_val=8744),
> > > On 2016/09/23 20:37:41, nxia1 wrote:
> > > > Looked into branch stabilize-8798.B and factory-reef-8811.B, they don't
> > > support
> > > > --git-cache-dir yet. I think we can just disable supports_git_cache for
> > > tryjobs
> > > > for now. When we get a right git_cache_min_branch_version, we can enable
> the
> > > > git-cache on tryjobs?
> > > 
> > > Well, ToT right now is pushing 8829, so how about we go with that?
> > 
> > 8829 should be good. Let's set it as the default min_branch_version.
> 
> Done.
> 
> For the record, it's good to reply to the code review comment when possible
> rather than the text at the bottom. This keeps comments about code local to
> their location in the code.


lgtm.

good to know how to play with the review system :)

[nxia1, 2016-09-26 17:43:47]

can we get this CL reviewed?

[dnj, 2016-09-26 18:26:22]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:26:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:30:47]

Description was changed from

==========
Enable --git-cache-dir option in chromite/cbuildbot.

Run chromite/cbuildbot with --git-cache-dir='/b/cros_git_cache'. This
allows repo sync to bootstrap empty projects from git-cache instead of
fetching directly from GoB.

Also, track Chromite branch version in config for use in feature flag
evaluation.

BUG=chromium:632203
TEST=expectations
==========

to

==========
Enable --git-cache-dir option in chromite/cbuildbot.

Run chromite/cbuildbot with --git-cache-dir='/b/cros_git_cache'. This
allows repo sync to bootstrap empty projects from git-cache instead of
fetching directly from GoB.

Also, track Chromite branch version in config for use in feature flag
evaluation.

BUG=chromium:632203
TEST=expectations

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/20f18fa6ef3826733e86...
==========

[commit-bot: I haz the power, 2016-09-26 18:30:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/20f18fa6ef3826733e86...