Issue 23650005: chrome://crashes: reload uploads.log every time the page refreshes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23650005: chrome://crashes: reload uploads.log every time the page refreshes (Closed)

Created:
7 years, 3 months ago by vapier

Modified:
7 years, 2 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome://crashes: reload uploads.log every time the page refreshes The current crashes UI logic will read the uploads.log file once when the tab is created. The intention is for it to be read when we get a callback from the javascript code. So even though we do register a JS callback, that only serves to generate the UI, not update the backing store. Refactor the code so that we do reload the log whenever the JS code calls us to do it. BUG=chromium:212728 TEST=loaded chrome://crashes, triggered a new crash, then refreshed the existing tab

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -11 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/crashes.html	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/crashes.js	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/crashes_ui.cc	View	1	7 chunks	+29 lines, -0 lines	0 comments	Download
M	chromeos/dbus/debug_daemon_client.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/dbus/debug_daemon_client.cc	View	1	5 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Are you aware of https://codereview.chromium.org/23020015/ ? You probably want a webui OWNER to review this. ...

7 years, 3 months ago (2013-09-13 18:10:42 UTC) #2

vapier

7 years, 2 months ago (2013-10-07 21:59:49 UTC) #3

Message was sent while issue was closed.

don't need this anymore as the other CL has been merged by Albert

Expand Messages | Collapse Messages