Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 2364943002: Create NavigationHandles for interstitials if needed (Closed)
Patch Set: Fixed Android issue Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index f6059d71e0ea72f4953cef9191bc9826507304b1..18d12057910e42cb264d6d58d7e967fbfa0d6d29 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -126,6 +126,16 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
NavigationData* GetNavigationData() override;
+ // The NavigatorDelegate to notify/query for various navigation events.
+ // Normally this is the WebContents, except if this NavigationHandle was
+ // created during a navigation to an interstitial page. In this case it will
+ // be the InterstitialPage itself.
+ //
+ // Note: due to the interstitial navigation case, all calls that can possibly
+ // expose the NavigationHandle to code outside of content/ MUST go though the
+ // NavigatorDelegate. In particular, the ContentBrowserClient should not be
+ // called directly form the NavigationHandle code. Thus, these calls will not
+ // expose the NavigationHandle when navigating to an InterstialPage.
NavigatorDelegate* GetDelegate() const;
RequestContextType GetRequestContextType() const;
« no previous file with comments | « content/browser/frame_host/interstitial_page_navigator_impl.cc ('k') | content/browser/frame_host/navigation_handle_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698