Create NavigationHandles for interstitials if needed

content/browser/frame_host/interstitial_page_navigator_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_NAVIGATOR_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_NAVIGATOR_IMPL_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "content/browser/frame_host/navigation_handle_impl.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/common/content_export.h"
 
 namespace content {
 
 class NavigationControllerImpl;
 class InterstitialPageImpl;
 
 // Navigator implementation specific to InterstialPageImpl. It allows only one
 // navigation to commit, since interstitial pages are not allowed to navigate.
 class CONTENT_EXPORT InterstitialPageNavigatorImpl : public Navigator {
  public:
   InterstitialPageNavigatorImpl(
       InterstitialPageImpl* interstitial,
       NavigationControllerImpl* navigation_controller);
 
   NavigatorDelegate* GetDelegate() override;
   NavigationController* GetController() override;
+  void DidStartProvisionalLoad(
+      RenderFrameHostImpl* render_frame_host,
+      const GURL& url,
+      const base::TimeTicks& navigation_start) override;
   void DidNavigate(RenderFrameHostImpl* render_frame_host,
                    const FrameHostMsg_DidCommitProvisionalLoad_Params&
                        input_params) override;
+  NavigationHandleImpl* GetNavigationHandleForFrameHost(
+      RenderFrameHostImpl* render_frame_host) override;
 
  private:
-  ~InterstitialPageNavigatorImpl() override {}
+  ~InterstitialPageNavigatorImpl() override;
 
   // The InterstitialPage with which this navigator object is associated.
   // Non owned pointer.
   InterstitialPageImpl* interstitial_;
 
   // The NavigationController associated with this navigator.
   NavigationControllerImpl* controller_;
 
+  // The NavigationHandle associated with the interstitial navigation.

[Charlie Reis, 2016/09/23 18:51:11]

Let's add a note that interstitials are assumed to only have a single
RenderFrameHost, so it's ok to track the NavigationHandle here rather than
per-frame.

Let's also mention that we don't expect this to send DidStartNavigation or
DidFinishNavigation events to the WebContentsObserver, since those will go
through InterstitialPageImpl as the delegate and get dropped.

[clamy, 2016/09/26 11:37:27]

Done.

+  std::unique_ptr<NavigationHandleImpl> navigation_handle_;
+
   DISALLOW_COPY_AND_ASSIGN(InterstitialPageNavigatorImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_INTERSTITIAL_PAGE_NAVIGATOR_IMPL_H_