[heap] New heuristics for starting of incremental marking.

[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO

Committed: https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d
Cr-Commit-Position: refs/heads/master@{#39831}

[ulan, 2016-09-26 13:20:57]

Description was changed from

==========
[heap] Start incremental marking in tasks.

BUG=
==========

to

==========
[heap] New heuristics for starting incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

[ulan, 2016-09-26 13:24:24]

Description was changed from

==========
[heap] New heuristics for starting incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

[ulan, 2016-09-26 13:29:13]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org

[ulan, 2016-09-26 13:29:14]

PTAL

[Hannes Payer (out of office), 2016-09-27 09:16:53]

nice, lgtm

https://codereview.chromium.org/2364923002/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2364923002/diff/100001/src/heap/heap.cc#newco...
src/heap/heap.cc:5361: Heap::IncrementalMarkingLimit
Heap::ReachedIncrementalMarkingLimit() {
nit: maybe rename to IncrementalMarkingLimitReached

and rename the enum items to k*Reached

[ulan, 2016-09-27 17:06:41]

https://codereview.chromium.org/2364923002/diff/100001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2364923002/diff/100001/src/heap/heap.cc#newco...
src/heap/heap.cc:5361: Heap::IncrementalMarkingLimit
Heap::ReachedIncrementalMarkingLimit() {
On 2016/09/27 09:16:53, Hannes Payer wrote:
> nit: maybe rename to IncrementalMarkingLimitReached
> 
> and rename the enum items to k*Reached

Renamed the function.

[ulan, 2016-09-28 13:25:13]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 13:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 13:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 13:28:51]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/13639)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9824)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[ulan, 2016-09-28 14:10:36]

The CQ bit was checked by ulan@chromium.org

[ulan, 2016-09-28 14:10:37]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2364923002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-28 14:10:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:43:28]

Description was changed from

==========
[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

[commit-bot: I haz the power, 2016-09-28 14:43:29]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-28 14:44:26]

Description was changed from

==========
[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO
==========

to

==========
[heap] New heuristics for starting of incremental marking.

The motivation for this patch is to move more marking work to tasks.
This is done by postponing the start of incremental marking until
a marking task is running.

This patch introduces a soft and a hard limits for incremental marking.
When the soft limit is reached, the marking task is scheduled.
If the hard limit is reached before the task is running, then
incremental marking is started without waiting for the task.

BUG=chromium:616434
LOG=NO

Committed: https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d
Cr-Commit-Position: refs/heads/master@{#39831}
==========

[commit-bot: I haz the power, 2016-09-28 14:44:28]

Patchset 9 (id:??) landed as
https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d
Cr-Commit-Position: refs/heads/master@{#39831}

[Michael Achenbach, 2016-09-28 15:19:32]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2375983002/ by machenbach@chromium.org.

The reason for reverting is: OOMs in nosnap debug:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....