Suppress definition of snprintf in port_chromium.h which conflicts with base::snprintf.

Suppress definition of snprintf in port_chromium.h which conflicts with base::snprintf.

This definition breaks compile whenever a compilation unit happens to include string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to work
before when string_util.h was included after as the definition would also come out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which can use
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made env_mojo.cc
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf': is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in pending_task.h transitively
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered this issue.

BUG=649084
Committed: https://crrev.com/cf3416047e29d074bdc135488236bd72cbd7f97b
Cr-Commit-Position: refs/heads/master@{#421040}

[gab, 2016-09-23 20:19:48]

Description was changed from

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the definition of snprintf in base is replaced by
_snprintf
==========

to

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

[gab, 2016-09-23 20:22:26]

Patchset #1 (id:1) has been deleted

[gab, 2016-09-23 20:23:06]

Description was changed from

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

to

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which
can use 
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

[gab, 2016-09-23 20:23:16]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 20:23:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:20:55]

Dry run: This issue passed the CQ dry run.

[gab, 2016-09-23 22:35:04]

gab@chromium.org changed reviewers:
+ michaeln@chromium.org

[gab, 2016-09-23 22:35:04]

Michael PTAL, thanks

[gab, 2016-09-26 18:52:12]

On 2016/09/23 22:35:04, gab wrote:
> Michael PTAL, thanks

@michaeln: ping

[michaeln, 2016-09-26 19:56:06]

lgtm

[gab, 2016-09-26 20:44:35]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 23:42:48]

Description was changed from

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which
can use 
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

to

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which
can use 
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

[commit-bot: I haz the power, 2016-09-26 23:42:49]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-26 23:45:12]

Description was changed from

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which
can use 
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc 
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively 
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084
==========

to

==========
Suppress definition of snprintf in port_chromium.h which conflicts with
base::snprintf.

This definition breaks compile whenever a compilation unit happens to include
string_util.h
before port_chromium.h (as the defined base::snprintf() doesn't match the
callers
base::_snprintf() calls as replaced by the preprocessor)... This happened to
work
before when string_util.h was included after as the definition would also come
out as
base::_snprintf() thanks the preprocessor..!

The definition doesn't appear to be needed by anything but env_chromium.cc which
can use
base::snprintf instead.

This was discovered while adding a new header to pending_task.h which made
env_mojo.cc
hit a compile error:

src\third_party\leveldatabase\chromium_logger.h(46): error C2039: '_snprintf':
is not a member of 'base'
src\base\trace_event\trace_event.h(1137): note: see declaration of 'base'

after much digging, the issue was discovered to be that the new header in
pending_task.h transitively
caused env_mojo.cc to include string_util.h before port_chromium.h and triggered
this issue.

BUG=649084

Committed: https://crrev.com/cf3416047e29d074bdc135488236bd72cbd7f97b
Cr-Commit-Position: refs/heads/master@{#421040}
==========

[commit-bot: I haz the power, 2016-09-26 23:45:12]

Patchset 1 (id:??) landed as
https://crrev.com/cf3416047e29d074bdc135488236bd72cbd7f97b
Cr-Commit-Position: refs/heads/master@{#421040}